Issue 9491043: EmeraldTree: test cases and files ported to python 3 with backward compatibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9491043: EmeraldTree: test cases and files ported to python 3 with backward compatibility

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by chitrankdixit

Modified:
12 years ago

Reviewers:
thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

More Reviews

Description

EmeraldTree: test cases and files ported to python 3 with backward compatibility

Patch Set 1 #

Total comments: 9

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -14 lines)			Patch
M	emeraldtree/html.py	View	1 chunk	+8 lines, -3 lines	4 comments	Download
M	emeraldtree/tests/test_html.py	View	1 chunk	+5 lines, -2 lines	2 comments	Download
M	emeraldtree/tests/test_tree.py	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	emeraldtree/tree.py	View	8 chunks	+8 lines, -8 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

https://codereview.appspot.com/9491043/diff/1/emeraldtree/html.py File emeraldtree/html.py (right): https://codereview.appspot.com/9491043/diff/1/emeraldtree/html.py#newcode39 emeraldtree/html.py:39: from html.parser import HTMLParser as HTMLParserBase six has tools ...

12 years ago (2013-05-20 16:23:48 UTC) #1

chitrankdixit

12 years ago (2013-05-21 01:57:29 UTC) #2

https://codereview.appspot.com/9491043/diff/1/emeraldtree/html.py
File emeraldtree/html.py (right):

https://codereview.appspot.com/9491043/diff/1/emeraldtree/html.py#newcode39
emeraldtree/html.py:39: from html.parser import HTMLParser as HTMLParserBase
I would use six but can not we make the code general and avoid using extra
module.

On 2013/05/20 16:23:48, Thomas.J.Waldmann wrote:
> six has tools for these cases.

https://codereview.appspot.com/9491043/diff/1/emeraldtree/html.py#newcode41
emeraldtree/html.py:41: 
Sorry for the tabs I'll fix it up

On 2013/05/20 16:23:48, Thomas.J.Waldmann wrote:
> you still use tabs. don't!

https://codereview.appspot.com/9491043/diff/1/emeraldtree/tests/test_html.py
File emeraldtree/tests/test_html.py (right):

https://codereview.appspot.com/9491043/diff/1/emeraldtree/tests/test_html.py#...
emeraldtree/tests/test_html.py:9: from io import StringIO
Probably using six is better choice sorry for my wrong understanding in porting.

On 2013/05/20 16:23:48, Thomas.J.Waldmann wrote:
> six has that, too

Expand All Messages | Collapse All Messages