Ported test cases of Moin2 for python 3.x with backward compatibility

Ported test cases of Moin2 :

-- Keeping in mind the similar behavior of functions and libraries after using 2to3.

[Thomas.J.Waldmann, 2013-05-19 19:45:00]

https://codereview.appspot.com/9478044/diff/1/MoinMoin/_tests/__init__.py
File MoinMoin/_tests/__init__.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/_tests/__init__.py#new...
MoinMoin/_tests/__init__.py:12: from io import StringIO
did you notice how that is different precisely?

https://codereview.appspot.com/9478044/diff/1/MoinMoin/apps/frontend/_tests/t...
File MoinMoin/apps/frontend/_tests/test_frontend.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/apps/frontend/_tests/t...
MoinMoin/apps/frontend/_tests/test_frontend.py:27: print('%s %s' % (method,
url_for(viewname, **viewopts)))
that does not work on python 2

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
File MoinMoin/converter/_tests/test__args_wiki.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test__args_wiki.py:24: u'''"a b\tc\nd" k="a
b\tc\nd"''',
you realized that this means something different now?

why did you change it?

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
File MoinMoin/converter/_tests/test_docbook_out.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test_docbook_out.py:11: 
don't do unintended changes - and NEVER use tabs

https://codereview.appspot.com/9478044/diff/1/MoinMoin/datastruct/backends/_t...
File MoinMoin/datastruct/backends/_tests/__init__.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/datastruct/backends/_t...
MoinMoin/datastruct/backends/_tests/__init__.py:48: for group, members in
self.expanded_groups.items():
that means something a bit different when run on py2

https://codereview.appspot.com/9478044/diff/1/MoinMoin/datastruct/backends/_t...
MoinMoin/datastruct/backends/_tests/__init__.py:148: for dict_name,
expected_dict in list(expected_dicts.items()):
why?

https://codereview.appspot.com/9478044/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:200: testfile =
os.path.join(abspath,a,'contrib', 'interwiki', 'intermap.txt')
that's unrelated and i think we already talked about it

[chitrankdixit, 2013-05-20 13:01:28]

Reason replacing 
from StringIO import StringIO

and using 
from io import StringIO

for both py2 and py3.

https://codereview.appspot.com/9478044/diff/1/MoinMoin/_tests/__init__.py
File MoinMoin/_tests/__init__.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/_tests/__init__.py#new...
MoinMoin/_tests/__init__.py:12: from io import StringIO
StringIO is not included in py3 as seperate Library it is included in "io"
library.

On the other hand StringIO also exists in py2 "io" library so it would be better
to use "io" library that could suit both the versions of python. 

used the test on both python 2.7 and python 3.3
for python2 : 
https://www.pythonanywhere.com/user/Chitrank/consoles/python2.7/245764/

for python3 :
https://www.pythonanywhere.com/user/Chitrank/consoles/python3.3/245765/

Sorry if not able to view as pythonanywhere requires userlogin. but work on both
the python referred Python documentation
http://docs.python.org/2/library/stringio.html

http://docs.python.org/2/library/io.html
http://docs.python.org/3/library/io.html?highlight=stringio#io.StringIO


On 2013/05/19 19:45:00, Thomas.J.Waldmann wrote:
> did you notice how that is different precisely?

[chitrankdixit, 2013-05-20 13:58:37]

https://codereview.appspot.com/9478044/diff/1/MoinMoin/apps/frontend/_tests/t...
File MoinMoin/apps/frontend/_tests/test_frontend.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/apps/frontend/_tests/t...
MoinMoin/apps/frontend/_tests/test_frontend.py:27: print('%s %s' % (method,
url_for(viewname, **viewopts)))
I have used the test case
--print('%s %s' % ('Moin','Wiki'))--
and this works well on both python2 and python3

P.S: If I am not getting in what respect the change does not work then Please
let me know. 

On 2013/05/19 19:45:00, Thomas.J.Waldmann wrote:
> that does not work on python 2

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
File MoinMoin/converter/_tests/test__args_wiki.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test__args_wiki.py:24: u'''"a b\tc\nd" k="a
b\tc\nd"''',
Yes Thomas a bit confused over this as raw unicode literals  are used
differently in python 3.x. raw literals puts an extra slash so the the Escape
sequence also treated as simple strings.

simple raw string literals can be used but using raw unicode literals gives
SyntaxError. This is not included in python 3.

On the other hand raw byte strings are working well.

So should I use try catch instead to use ur -literal for py2 and rb -literal for
py3. ? 

On 2013/05/19 19:45:00, Thomas.J.Waldmann wrote:
> you realized that this means something different now?
> 
> why did you change it?

https://codereview.appspot.com/9478044/diff/1/MoinMoin/datastruct/backends/_t...
File MoinMoin/datastruct/backends/_tests/__init__.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/datastruct/backends/_t...
MoinMoin/datastruct/backends/_tests/__init__.py:48: for group, members in
self.expanded_groups.items():
items() return the list of tuples of key,value pairs. This takes up the full
space whether or not the iteration proceeds further. The change may result in
this problem.

Whereas iteritems() is a generator object that get the memory as per the
iteration proceeds 

but items() are for backward compatibility and items() in py3 works as
iteritems(). So I used this.

Should I use the try except and make it more better ?



On 2013/05/19 19:45:00, Thomas.J.Waldmann wrote:
> that means something a bit different when run on py2

https://codereview.appspot.com/9478044/diff/1/MoinMoin/datastruct/backends/_t...
MoinMoin/datastruct/backends/_tests/__init__.py:148: for dict_name,
expected_dict in list(expected_dicts.items()):
Sorry for this Useless change would fix this soon.

On 2013/05/19 19:45:00, Thomas.J.Waldmann wrote:
> why?

https://codereview.appspot.com/9478044/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:200: testfile =
os.path.join(abspath,a,'contrib', 'interwiki', 'intermap.txt')
Sorry Thomas for this change Please do not consider this.
Its my mistake

On 2013/05/19 19:45:00, Thomas.J.Waldmann wrote:
> that's unrelated and i think we already talked about it

[Thomas.J.Waldmann, 2013-05-23 08:51:35]

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
File MoinMoin/converter/_tests/test__args_wiki.py (right):

https://codereview.appspot.com/9478044/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test__args_wiki.py:24: u'''"a b\tc\nd" k="a
b\tc\nd"''',
if you convert a ur'' string into a u'' string, you have to escape it.
e.g.: \ usually becomes \\

ur'' strings are not supported in py 3.3