I updated the xcode project to remove the console warning we were seeing. A while ...
17 years, 1 month ago
(2008-11-20 17:26:43 UTC)
#1
I updated the xcode project to remove the console warning we were seeing. A
while ago I had accidentally duplicated a reference to the gtest.framework build
product.
Also, I ordered the target lists in the same order as the runtests.sh executes
the tests. This will help us more easily verify changes since all lists will be
in the same order.
Finally, I added "executables" for the python tests such that they can be
executed from within Xcode.
Guys, "Take two," on this review. I reordered the targets to reflect the order in ...
17 years, 1 month ago
(2008-11-21 17:51:56 UTC)
#2
Guys,
"Take two," on this review. I reordered the targets to reflect the order in the
new make file (alphabetically in function group). Also, I added Zhanyong's
suggested changes to the target names. Here's how it works
Non-python tests have a target name, the same name as the .cc file (without the
suffix). This part hasn't changed
Python-based tests have two targets. The first one (with a trailing underscore
in the name) simply builds the .cc file into an executable. The second target
(without the trailing underscore) ensures the first target has been built, and
then copies over the necessary python scripts to the build directory.
As with the previous review, I removed the console warning, and added custom
executables to run the python script from within Xcode (but not xcodebuild).
Please take a look, when you get a chance.
This looks good. I just have one question. I verified that: - the warning is ...
17 years, 1 month ago
(2008-11-21 21:38:39 UTC)
#4
This looks good. I just have one question.
I verified that:
- the warning is gone.
- the build targets have the correct names.
- xcodebuild [-configuration Debug] succeeds.
- xcodebuild [-configuration Debug] -target Check works fine except for
gtest_output_test failing, which is a known issue.
Please submit!
http://codereview.appspot.com/9451/diff/10/210
File xcode/Config/InternalPythonTestTarget.xcconfig (right):
http://codereview.appspot.com/9451/diff/10/210#newcode8
Line 8: HEADER_SEARCH_PATHS = ../ ../include
I'm curious why we didn't need this file before and need it now.
Issue 9451: Update xcode project with custom executables for the pythonn tests and removes a console warning
Created 17 years, 1 month ago by Preston Jackson
Modified 11 years, 1 month ago
Reviewers: wan, vladl_google.com, Zhanyong
Base URL: http://googletest.googlecode.com/svn/trunk/
Comments: 1