Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(315)

Issue 9451: Update xcode project with custom executables for the pythonn tests and removes a console warning

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by Preston Jackson
Modified:
11 years, 1 month ago
Reviewers:
Zhanyong, wan, vladl
CC:
opensource-gtest_google.com
Base URL:
http://googletest.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Reordered targets alphabetcially annd changed naming scheme for python test targets #

Patch Set 3 : Additional tweaking to the target names #

Patch Set 4 : README tuning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -448 lines) Patch
README View 2 3 2 chunks +9 lines, -11 lines 0 comments Download
xcode/Config/InternalPythonTestTarget.xcconfig View 1 chunk +8 lines, -0 lines 1 comment Download
xcode/Scripts/runtests.sh View 1 chunk +10 lines, -10 lines 0 comments Download
xcode/gtest.xcodeproj/project.pbxproj View 1 2 90 chunks +416 lines, -427 lines 0 comments Download

Messages

Total messages: 5
Preston Jackson
I updated the xcode project to remove the console warning we were seeing. A while ...
17 years, 1 month ago (2008-11-20 17:26:43 UTC) #1
Preston Jackson
Guys, "Take two," on this review. I reordered the targets to reflect the order in ...
17 years, 1 month ago (2008-11-21 17:51:56 UTC) #2
Preston Jackson
Ok, "Take three" on this review. Let me know if there are outstanding issues. I'm ...
17 years, 1 month ago (2008-11-21 19:59:46 UTC) #3
Zhanyong
This looks good. I just have one question. I verified that: - the warning is ...
17 years, 1 month ago (2008-11-21 21:38:39 UTC) #4
Zhanyong
17 years, 1 month ago (2008-11-21 21:39:12 UTC) #5
BTW, I also verified that the order of the target in the sh script is correct.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b