Issue 945042: Partial Wine support in TSan.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 945042: Partial Wine support in TSan.

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Evgeniy Stepanov

Modified:
15 years, 8 months ago

Reviewers:
kcc, Timur Iskhodzhanov

Base URL:
http://data-race-test.googlecode.com/svn/trunk/tsan/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : zz #

Total comments: 4

Patch Set 3 : Restored warning "T%d ended while the 'ignore %s' bit is set" #

Patch Set 4 : Submitted parts of this CLs. #

Patch Set 5 : zz #

Patch Set 6 : zz #

Patch Set 7 : ZlZr -> Za #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -12 lines)			Patch
	M	ts_valgrind.cc	View	1	3 chunks	+20 lines, -6 lines	0 comments	Download
	M	ts_valgrind_intercepts.c	View	1 5 6	16 chunks	+44 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Timur Iskhodzhanov

15 years, 8 months ago (2010-04-21 10:50:02 UTC) #2

http://codereview.appspot.com/945042/diff/2001/3007
File tsan/ts_valgrind.cc (right):

http://codereview.appspot.com/945042/diff/2001/3007#newcode666
tsan/ts_valgrind.cc:666: if (ignoring_sync(vg_tid))
probably we should move this to thread_sanitizer.cc so it works on PIN

http://codereview.appspot.com/945042/diff/2001/3007#newcode677
tsan/ts_valgrind.cc:677: break;
no "{}" needed

http://codereview.appspot.com/945042/diff/2001/3006
File tsan/ts_valgrind_intercepts.c (left):

http://codereview.appspot.com/945042/diff/2001/3006#oldcode2480
tsan/ts_valgrind_intercepts.c:2480: 
...

http://codereview.appspot.com/945042/diff/2001/3006
File tsan/ts_valgrind_intercepts.c (right):

http://codereview.appspot.com/945042/diff/2001/3006#newcode493
tsan/ts_valgrind_intercepts.c:493: WRAP_FREE_ZZ(NONE, operatorZsdelete);
WRAP_DELETE?

Expand All Messages | Collapse All Messages