Use lxc clone by default

environs/config_test.go

 // Copyright 2011, 2012, 2013 Canonical Ltd.
 // Licensed under the AGPLv3, see LICENCE file for details.
 
 package environs_test
 
 import (
         "fmt"
         "os"
         "path/filepath"
         "sort"
@@ skipping 89 matching lines @@
         defer testing.MakeFakeHomeNoEnvironments(c, "only").Restore()
         content := `
 environments:
     valid:
         type: dummy
         state-server: false
     deprecated:
         type: dummy
         state-server: false
         tools-url: aknowndeprecatedfield
+        lxc-use-clone: true
 `
         tw := &loggo.TestWriter{}
         // we only capture Warning or above
         c.Assert(loggo.RegisterWriter("invalid-env-tester", tw, loggo.WARNING), gc.IsNil)
         defer loggo.RemoveWriter("invalid-env-tester")
 
         envs, err := environs.ReadEnvironsBytes([]byte(content))
         c.Check(err, gc.IsNil)
         names := envs.Names()
         sort.Strings(names)
         c.Check(names, gc.DeepEquals, []string{"deprecated", "valid"})
         // There should be no warning in the log
         c.Check(tw.Log, gc.HasLen, 0)
         // Now we actually grab the 'valid' entry
         _, err = envs.Config("valid")
         c.Check(err, gc.IsNil)
         // And still we have no warnings
         c.Check(tw.Log, gc.HasLen, 0)
         // Only once we grab the deprecated one do we see any warnings
         _, err = envs.Config("deprecated")
         c.Check(err, gc.IsNil)
-        c.Check(tw.Log, gc.HasLen, 1)
+        c.Check(tw.Log, gc.HasLen, 2)
 }
 
 func (*suite) TestNoHomeBeforeConfig(c *gc.C) {
         // Test that we don't actually need HOME set until we call envs.Config()
         // Because of this, we intentionally do *not* call testing.MakeFakeHomeNoEnvironments()
         content := `
 environments:
     valid:
         type: dummy
     amazon:
@@ skipping 306 matching lines @@
                 `.*Config attribute "tools-url" \(aknowndeprecatedfield\) is deprecated and will be ignored since` +
                         `the new tools URL attribute "tools-metadata-url".*`)
         s.checkDeprecationWarning(c, attrs, expected)
 }
 
 func (s *ConfigDeprecationSuite) TestDeprecatedTypeNullWarning(c *gc.C) {
         attrs := testing.Attrs{"type": "null"}
         expected := `Provider type \"null\" has been renamed to \"manual\"\.Please update your environment configuration\.`
         s.checkDeprecationWarning(c, attrs, expected)
 }
+
+func (s *ConfigDeprecationSuite) TestDeprecatedLxcUseCloneWarning(c *gc.C) {
+        attrs := testing.Attrs{"lxc-use-clone": true}
+        expected := `Config attribute \"lxc-use-clone\" has been renamed to \"lxc-clone\".Please update your environment configuration\.`
+        s.checkDeprecationWarning(c, attrs, expected)
+}