Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5943)

Issue 9427043: Store optimization level in program binaries and do not load those compiled with a different level. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by apatrick1
Modified:
10 years, 11 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/branches/dx11proto/
Visibility:
Public.

Description

Store optimization level in program binaries and do not load those compiled with a different level. Committed: https://code.google.com/p/angleproject/source/detail?r=2213

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/common/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/libGLESv2/ProgramBinary.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/Renderer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/libGLESv2/renderer/Renderer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/libGLESv2/renderer/Renderer9.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4
apatrick1
This is to avoid issues with compilation flags changing during development while the ANGLE version ...
10 years, 11 months ago (2013-05-15 00:28:06 UTC) #1
nicolas%transgaming.com
Seems like a prudent thing to do. Please also make sure BUILD_REVISION in version.h is ...
10 years, 11 months ago (2013-05-15 02:40:29 UTC) #2
apatrick1
Oh and this was the issue with the dx11proto branch! I thought I was changing ...
10 years, 11 months ago (2013-05-15 18:08:33 UTC) #3
nicolas%transgaming.com
10 years, 11 months ago (2013-05-15 18:34:36 UTC) #4
On 2013/05/15 18:08:33, apatrick1 wrote:
> Oh and this was the issue with the dx11proto branch! I thought I was changing
> the optimization level when it was really using old cached level 1 binaries
from
> a previous run.

Excellent! I was wondering about that, but forgot to ask during the review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b