Issue 9413043: Add man files of /usr/bin files.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9413043: Add man files of /usr/bin files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by fujiwara

Modified:
11 years, 6 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Patch Set 2 : Updated with message #2. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -6 lines)			Patch
M	bus/Makefile.am	View	1	4 chunks	+19 lines, -2 lines	0 comments	Download
A	bus/ibus-daemon.1.in	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
M	setup/Makefile.am	View	1	2 chunks	+16 lines, -2 lines	0 comments	Download
A	setup/ibus-setup.1.in	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
M	tools/Makefile.am	View	1	2 chunks	+19 lines, -2 lines	0 comments	Download
A	tools/ibus.1.in	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm with several comments https://codereview.appspot.com/9413043/diff/1/bus/Makefile.am File bus/Makefile.am (right): https://codereview.appspot.com/9413043/diff/1/bus/Makefile.am#newcode6 bus/Makefile.am:6: # Copyright (c) 2007-2010 Red ...

11 years, 6 months ago (2013-05-14 14:42:22 UTC) #2

fujiwara

11 years, 6 months ago (2013-05-15 02:50:48 UTC) #3

https://codereview.appspot.com/9413043/diff/1/bus/Makefile.am
File bus/Makefile.am (right):

https://codereview.appspot.com/9413043/diff/1/bus/Makefile.am#newcode6
bus/Makefile.am:6: # Copyright (c) 2007-2010 Red Hat, Inc.
On 2013/05/14 14:42:22, Peng wrote:
> Update the date in license header

Done.

https://codereview.appspot.com/9413043/diff/1/bus/ibus-daemon.1
File bus/ibus-daemon.1 (right):

https://codereview.appspot.com/9413043/diff/1/bus/ibus-daemon.1#newcode6
bus/ibus-daemon.1:6: .TH IBUS-DAEMON "1" "April 2010" "ibus-daemon 1.3.1" "User
Commands"
On 2013/05/14 14:42:22, Peng wrote:
> Is the version right?

OK, I renamed *.1 to *.1.in to save the version numbers.

Expand All Messages | Collapse All Messages