code review 94100044: go.tools/imports: now treat imports like 'pg.v1' as jus...

go.tools/imports: now treat imports like 'pg.v1' as just 'pg' for fixing

Fixes issue 7942.

[lk4d4, 2014-05-06 05:14:24]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[crawshaw, 2014-05-06 12:59:27]

I don't understand why this isn't handled by the package scanning, which now
understands that a package name can vary from the last part of its path.

Perhaps if you add a test, all will become clear.

[bradfitz, 2014-05-06 17:40:01]

I don't think this patch is necessary.  It's hard-coding gopkg.in behavior
rather than just using a GOPATH, which we already handle.  I closed the bug
as WorkingAsIntended.  Feel free to re-open if I'm not understanding the
problem.



On Tue, May 6, 2014 at 5:59 AM, <crawshaw@golang.org> wrote:

> I don't understand why this isn't handled by the package scanning, which
> now understands that a package name can vary from the last part of its
> path.
>
> Perhaps if you add a test, all will become clear.
>
> https://codereview.appspot.com/94100044/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[bradfitz, 2014-12-11 02:21:29]

R=close

[sec.test.dragnet, 2025-06-22 23:57:06]

irrelevant

[sec.test.dragnet, 2025-06-22 23:57:06]

irrelevant

[sec.test.dragnet, 2025-06-22 23:57:07]

irrelevant

[sec.test.dragnet, 2025-06-22 23:57:07]

irrelevant