Issue 93990043: lxc and kvm broker fake tools for other series

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93990043: lxc and kvm broker fake tools for other series

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by gz

Modified:
10 years, 8 months ago

Reviewers:
dimitern, mp+217813

Visibility:
Public.

Description

lxc and kvm broker fake tools for other series Cherrypick of r2583 from trunk. Currently the lxc and kvm brokers only create the same series containers as the host, even if a different series is asked for. Since the series is determined by the tools, we tweak the possible tools in order to give the right series. Original review: https://codereview.appspot.com/85220043/ https://code.launchpad.net/~gz/juju-core/1.18_backport_1302820/+merge/217813 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/lxc/initialisation.go	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	container/lxc/initialisation_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/tools.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/apt.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	worker/provisioner/container_initialisation_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/kvm-broker.go	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	worker/provisioner/kvm-broker_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/lxc-broker.go	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	worker/provisioner/lxc-broker_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/provisioner_task.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

10 years, 8 months ago (2014-04-30 19:24:05 UTC) #2

LGTM with one question, I guess for Tim or Ian?

https://codereview.appspot.com/93990043/diff/1/container/lxc/initialisation.go
File container/lxc/initialisation.go (right):

https://codereview.appspot.com/93990043/diff/1/container/lxc/initialisation.g...
container/lxc/initialisation.go:13: "cloud-image-utils",
Why do we need this - it doesn't seem we use anything from that package?

Expand All Messages | Collapse All Messages