Issue 9394043: Update App Engine sample to python27 runtime.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9394043: Update App Engine sample to python27 runtime. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by jcgregorio_google

Modified:
12 years, 5 months ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Update App Engine sample to python27 runtime.

Patch Set 2 : fix imports #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -31 lines)			Patch
	M	samples/appengine/app.yaml	View		1 chunk	+9 lines, -3 lines	0 comments	Download
	M	samples/appengine/main.py	View	1	3 chunks	+27 lines, -28 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/9394043/diff/2001/samples/appengine/main.py File samples/appengine/main.py (right): https://codereview.appspot.com/9394043/diff/2001/samples/appengine/main.py#newcode45 samples/appengine/main.py:45: extensions=['jinja2.ext.autoescape']) Is this actually needed? Doesn't Jinja do ...

12 years, 6 months ago (2013-05-14 04:09:33 UTC) #2

jcgregorio_google

12 years, 5 months ago (2013-05-16 19:58:22 UTC) #3

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=836901247f...

On 2013/05/14 04:09:33, dhermes wrote:
> LGTM
> 
> https://codereview.appspot.com/9394043/diff/2001/samples/appengine/main.py
> File samples/appengine/main.py (right):
> 
>
https://codereview.appspot.com/9394043/diff/2001/samples/appengine/main.py#ne...
> samples/appengine/main.py:45: extensions=['jinja2.ext.autoescape'])
> Is this actually needed? Doesn't Jinja do this out of the box anyway?

Expand All Messages | Collapse All Messages