ipv4/multicastsockopt_test.go - Issue 9353045: code review 9353045: go.net/ipv4: drop DIffServ and ECN constants, add ICMPType

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ipv4/multicastsockopt_test.go

Issue 9353045: code review 9353045: go.net/ipv4: drop DIffServ and ECN constants, add ICMPType (Closed)

Patch Set: diff -r 18808b83b019 https://code.google.com/p/go.net Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: ipv4/multicastsockopt_test.go

===================================================================

--- a/ipv4/multicastsockopt_test.go

+++ b/ipv4/multicastsockopt_test.go

@@ -33,8 +33,8 @@

}

var multicastSockoptTests = []multicastSockoptTest{

- {ipv4.DSCP_CS0 | ipv4.ECN_NOTECT, 127, 128, false, net.IPv4(224, 0, 0, 249)}, // see RFC 4727

- {ipv4.DSCP_AF11 | ipv4.ECN_NOTECT, 255, 254, true, net.IPv4(224, 0, 0, 250)}, // see RFC 4727

+ {DiffServCS0 | NotECNTransport, 127, 128, false, net.IPv4(224, 0, 0, 249)}, // see RFC 4727

+ {DiffServAF11 | NotECNTransport, 255, 254, true, net.IPv4(224, 0, 0, 250)}, // see RFC 4727

}

func TestUDPMulticastSockopt(t *testing.T) {

« no previous file with comments | « ipv4/multicast_test.go ('k') | ipv4/sockopt_bsd.go » ('j') | no next file with comments »