Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 93410044: Use relative paths for lists of source files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Rouslan Solomakhin
Modified:
9 years, 11 months ago
Reviewers:
roubert (google)
CC:
lararennie, dbeaumont, davinci_google
Base URL:
https://libaddressinput.googlecode.com/svn/trunk
Visibility:
Public.

Description

Use relative paths for lists of source files. This patch removes the libaddressinput_dir variable and renames: libaddressinput_[test_]sources -> libaddressinput_[test_]files String values contained within lists associated with keys ending in "_files" suffix are treated as pathnames relative to the file in which they are defined. https://code.google.com/p/gyp/wiki/InputFormatReference#Pathname_Relativization R=roubert@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -60 lines) Patch
M cpp/libaddressinput.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cpp/libaddressinput.gypi View 1 chunk +55 lines, -58 lines 0 comments Download

Messages

Total messages: 3
Rouslan Solomakhin
Fredrik: PTAL Patch Set 1.
9 years, 11 months ago (2014-05-15 05:14:33 UTC) #1
roubert (google)
LGTM
9 years, 11 months ago (2014-05-15 10:52:15 UTC) #2
Rouslan Solomakhin
9 years, 11 months ago (2014-05-15 11:43:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r216 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b