Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(495)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 93410043: Extract errors package to github.com/juju/errors

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by thumper
Modified:
10 years, 11 months ago
Reviewers:
mp+219608, axw, dave
Visibility:
Public.

Description

Extract errors package to github.com/juju/errors Also introduces a dependency on github.com/juju/errgo and removes the github.com/errgo/errgo dependency. Adds additional functions for simple tracing and annotations of errors. https://code.launchpad.net/~thumper/juju-core/juju-errors/+merge/219608 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -658 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/agent.go View 6 chunks +14 lines, -14 lines 0 comments Download
M agent/tools/toolsdir.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cert/cert.go View 2 chunks +3 lines, -4 lines 0 comments Download
M cmd/juju/bootstrap_test.go View 2 chunks +1 line, -1 line 0 comments Download
M cmd/juju/common.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/juju/debuglog.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/debuglog_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/deploy_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/destroyenvironment_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/removemachine_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/agent.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/bootstrap_test.go View 2 chunks +1 line, -1 line 0 comments Download
M cmd/jujud/machine.go View 2 chunks +1 line, -1 line 0 comments Download
M cmd/jujud/machine_test.go View 2 chunks +1 line, -1 line 0 comments Download
M constraints/constraints.go View 2 chunks +2 lines, -2 lines 0 comments Download
M container/kvm/container.go View 1 chunk +2 lines, -1 line 0 comments Download
M container/kvm/kvm.go View 1 chunk +1 line, -1 line 0 comments Download
M container/lxc/instance.go View 1 chunk +1 line, -1 line 0 comments Download
M dependencies.tsv View 1 chunk +2 lines, -1 line 0 comments Download
M environs/bootstrap/state.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/bootstrap/synctools.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/cloudinit.go View 2 chunks +2 lines, -3 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 4 chunks +3 lines, -4 lines 0 comments Download
M environs/config.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/config/config.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/configstore/disk.go View 3 chunks +5 lines, -6 lines 0 comments Download
M environs/configstore/disk_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/configstore/mem.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/emptystorage.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/emptystorage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/filestorage/filestorage.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/filestorage/filestorage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/httpstorage/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/httpstorage/storage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/imagemetadata/generate.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/jujutest/livetests.go View 2 chunks +1 line, -1 line 0 comments Download
M environs/jujutest/tests.go View 2 chunks +1 line, -1 line 0 comments Download
M environs/open.go View 2 chunks +2 lines, -3 lines 0 comments Download
M environs/open_test.go View 2 chunks +1 line, -1 line 0 comments Download
M environs/simplestreams/datasource.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/simplestreams/simplestreams.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/sshstorage/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/sshstorage/storage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools/simplestreams.go View 1 chunk +2 lines, -1 line 0 comments Download
M environs/tools/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools/tools_test.go View 2 chunks +1 line, -1 line 0 comments Download
D errors/errors.go View 1 chunk +0 lines, -210 lines 0 comments Download
D errors/errors_test.go View 1 chunk +0 lines, -209 lines 0 comments Download
M juju/api.go View 1 chunk +2 lines, -1 line 0 comments Download
M juju/apiconn_test.go View 2 chunks +1 line, -1 line 0 comments Download
M juju/conn.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/conn_test.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/azure/certfile.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/azure/environ.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/azure/instance.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/azure/instancetype.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/azure/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/azure/storage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/common/destroy_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/dummy/storage.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/ec2/ec2.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/ec2/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/environ_instance.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/joyent/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/storage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/local/environ.go View 3 chunks +2 lines, -3 lines 0 comments Download
M provider/local/instance.go View 1 chunk +2 lines, -1 line 0 comments Download
M provider/maas/environ.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/maas/environ_whitebox_test.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/maas/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/storage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/manual/environ.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/openstack/provider.go View 2 chunks +1 line, -1 line 0 comments Download
M provider/openstack/storage.go View 1 chunk +1 line, -1 line 1 comment Download
M state/addmachine.go View 1 chunk +1 line, -1 line 0 comments Download
M state/annotator.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/api/agent/machine_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/client.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/machiner/machiner_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/provisioner/provisioner_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/uniter/unit_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/upgrader/unitupgrader_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/upgrader/upgrader_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/admin.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/apiserver/charmrevisionupdater/updater.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/charmrevisionupdater/updater_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/charms.go View 7 chunks +25 lines, -25 lines 0 comments Download
M state/apiserver/client/api_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/client/client.go View 4 chunks +12 lines, -13 lines 0 comments Download
M state/apiserver/client/client_test.go View 2 chunks +1 line, -1 line 0 comments Download
M state/apiserver/client/destroy_test.go View 1 chunk +1 line, -1 line 1 comment Download
M state/apiserver/client/status.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/apiserver/common/errors.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/apiserver/common/errors_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/common/password_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/deployer/deployer_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/firewaller/firewaller_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/keymanager/keymanager.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/keyupdater/authorisedkeys.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/apiserver/machine/machiner.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/apiserver/provisioner/provisioner_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/uniter/uniter.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/apiserver/uniter/uniter_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/upgrader/unitupgrader_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/upgrader/upgrader_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/charm_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/cleanup.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/cleanup_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/configvalidator_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/conn_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/constraints.go View 1 chunk +1 line, -1 line 0 comments Download
M state/environ.go View 1 chunk +1 line, -1 line 0 comments Download
M state/environcapability_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/machine.go View 1 chunk +1 line, -1 line 0 comments Download
M state/machine_test.go View 2 chunks +1 line, -1 line 0 comments Download
M state/megawatcher.go View 1 chunk +1 line, -1 line 0 comments Download
M state/minimumunits.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/open.go View 2 chunks +1 line, -1 line 0 comments Download
M state/policy.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/prechecker_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relation.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relation_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relationunit.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relationunit_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/service.go View 1 chunk +1 line, -1 line 0 comments Download
M state/service_test.go View 2 chunks +1 line, -1 line 0 comments Download
M state/settings.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/settings_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state.go View 2 chunks +1 line, -1 line 0 comments Download
M state/state_test.go View 2 chunks +1 line, -1 line 0 comments Download
M state/status.go View 1 chunk +1 line, -1 line 0 comments Download
M state/tools_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/unit.go View 2 chunks +1 line, -1 line 0 comments Download
M state/unit_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/user.go View 1 chunk +1 line, -1 line 0 comments Download
M state/watcher.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/authenticationworker/worker.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/deployer/deployer_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/firewaller/firewaller.go View 6 chunks +6 lines, -6 lines 0 comments Download
M worker/instancepoller/aggregate.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/instancepoller/aggregate_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M worker/instancepoller/machine_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/instancepoller/updater.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/peergrouper/mock_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/peergrouper/worker.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/kvm-broker_test.go View 2 chunks +1 line, -1 line 0 comments Download
M worker/provisioner/lxc-broker_test.go View 2 chunks +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner_test.go View 2 chunks +1 line, -1 line 0 comments Download
M worker/rsyslog/worker.go View 4 chunks +7 lines, -7 lines 0 comments Download
M worker/uniter/charm/bundles.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/relation/relation.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/relationer_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/state.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/uniter/uniter_test.go View 2 chunks +1 line, -1 line 0 comments Download
M worker/upgrader/upgrader_test.go View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3
thumper
Please take a look.
10 years, 11 months ago (2014-05-14 21:56:50 UTC) #1
axw
LGTM with a minor renaming https://codereview.appspot.com/93410043/diff/1/provider/openstack/storage.go File provider/openstack/storage.go (right): https://codereview.appspot.com/93410043/diff/1/provider/openstack/storage.go#newcode12 provider/openstack/storage.go:12: coreerrors "github.com/juju/errors" s/coreerrors/jujuerrors/ https://codereview.appspot.com/93410043/diff/1/state/apiserver/client/destroy_test.go ...
10 years, 11 months ago (2014-05-15 01:48:56 UTC) #2
dave_cheney.net
10 years, 11 months ago (2014-05-15 03:01:48 UTC) #3 
LGTM. I have the same comment as axw about renaming the juju/errors import. Can
that be avoided -- it's totally cool to defer that to a later branch and leave
this as the mechanical translation.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b