Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 9333044: code review 9333044: net/http/fs.go: add TCP_CORK routine for ResponseWriter...

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by pabuhr
Modified:
12 years ago
Reviewers:
golang-dev, mikio, bradfitz
Visibility:
Public.

Description

src/pkg/net/sockopt_linux.go: add TCP_CORK routine to toggle corking src/pkg/net/tcpsock_posix.go: add TCP_CORK member to TCPConn

Patch Set 1 #

Patch Set 2 : diff -r dc922c5176b5 https://code.google.com/p/go #

Patch Set 3 : diff -r dc922c5176b5 https://code.google.com/p/go #

Total comments: 3

Patch Set 4 : diff -r dc922c5176b5 https://code.google.com/p/go #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/pkg/net/sockopt_linux.go View 1 1 chunk +13 lines, -0 lines 4 comments Download
M src/pkg/net/tcpsock_posix.go View 1 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 9
pabuhr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-05-09 22:28:44 UTC) #1
bradfitz
CL description's first line should be: net: add TCPConn.SetNoPush Actually that's probably a good complete ...
12 years, 3 months ago (2013-05-09 22:35:19 UTC) #2
mikio
Can we make a new package called go.net/tcp instead? I now see some desirable operations ...
12 years, 3 months ago (2013-05-12 11:43:27 UTC) #3
bradfitz
On Sun, May 12, 2013 at 4:43 AM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > Can we ...
12 years, 3 months ago (2013-05-12 17:33:20 UTC) #4
mikio
On Mon, May 13, 2013 at 2:33 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > It would ...
12 years, 3 months ago (2013-05-13 00:03:26 UTC) #5
bradfitz
On Sun, May 12, 2013 at 5:03 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > On Mon, ...
12 years, 3 months ago (2013-05-13 00:04:30 UTC) #6
mikio
https://codereview.appspot.com/9333044/diff/12001/src/pkg/net/sockopt_linux.go File src/pkg/net/sockopt_linux.go (right): https://codereview.appspot.com/9333044/diff/12001/src/pkg/net/sockopt_linux.go#newcode53 src/pkg/net/sockopt_linux.go:53: func setNoPush(s int, value bool) error { please make ...
12 years, 3 months ago (2013-05-13 00:29:02 UTC) #7
bradfitz
Please close this CL. We've decided to do it in net/http instead.
12 years, 3 months ago (2013-05-14 22:22:51 UTC) #8
bradfitz
12 years ago (2013-07-23 16:38:16 UTC) #9
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b