Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 93010046: code review 93010046: ssh/terminal: handles interruptions in user-friendly manner

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by mon.nawrot
Modified:
7 years, 1 month ago
Reviewers:
CC:
golang-codereviews, agl1
Visibility:
Public.

Description

ssh/terminal: handles interruptions in user-friendly manner Fix issue 7939.

Patch Set 1 #

Patch Set 2 : diff -r a3d6743eb586 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r a3d6743eb586 https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r a3d6743eb586 https://code.google.com/p/go.crypto/ #

Total comments: 8

Patch Set 5 : diff -r a3d6743eb586 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M ssh/terminal/terminal.go View 1 2 3 4 4 chunks +20 lines, -1 line 0 comments Download
M ssh/terminal/terminal_test.go View 1 2 3 4 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8
mon.nawrot
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto/
7 years, 8 months ago (2014-05-05 06:34:31 UTC) #1
agl1
NACK. This is an API change for one. Code would also need to be able ...
7 years, 8 months ago (2014-05-05 19:09:47 UTC) #2
mon.nawrot
Fair enough. I took a closer look at the terminal code. It implements only editing ...
7 years, 8 months ago (2014-05-06 05:11:54 UTC) #3
agl1
On 2014/05/06 05:11:54, mon.nawrot wrote: > Fair enough. I took a closer look at the ...
7 years, 8 months ago (2014-05-06 16:55:48 UTC) #4
mon.nawrot
On 2014/05/06 16:55:48, agl1 wrote: > On 2014/05/06 05:11:54, mon.nawrot wrote: > > Fair enough. ...
7 years, 8 months ago (2014-05-12 05:37:27 UTC) #5
agl1
https://codereview.appspot.com/93010046/diff/60001/ssh/terminal/terminal.go File ssh/terminal/terminal.go (right): https://codereview.appspot.com/93010046/diff/60001/ssh/terminal/terminal.go#newcode46 ssh/terminal/terminal.go:46: // SignalHandler, if non-null, is called when ^C or ...
7 years, 8 months ago (2014-05-14 18:15:57 UTC) #6
mon.nawrot
https://codereview.appspot.com/93010046/diff/60001/ssh/terminal/terminal.go File ssh/terminal/terminal.go (right): https://codereview.appspot.com/93010046/diff/60001/ssh/terminal/terminal.go#newcode46 ssh/terminal/terminal.go:46: // SignalHandler, if non-null, is called when ^C or ...
7 years, 8 months ago (2014-05-26 05:58:34 UTC) #7
gobot
7 years, 1 month ago (2014-12-19 05:19:02 UTC) #8
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/93010046 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b