code review 929041: big: Get rid of function pointers and init function

big: Get rid of function pointers and init function

[eds, 2010-04-18 17:34:40]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-04-18 18:42:44]

Renaming the routines so that there's no _s sufix on the assembly
seems okay - that gets rid of an indirect for all the calls - but I'd like
to keep the portable versions and the ARM stubs that just jump to them.
Keeping the portable versions means that they can still be tested
at the same time as the assembly versions.  The linker is smart enough
not to include them in binaries that don't use them explicitly.
So I'd suggest that instead, this change should drop the _s suffixes
and the pointers but leave everything else alone.

Russ

[eds, 2010-04-18 18:59:29]

Oops, I just realized I forgot the new files in this CL. I moved the
assembly function declarations to arith_decl.go and the portable
versions to arith_go.go which gets compiled if there's no version
available for the target arch. Maybe knowing that will help this CL
make more sense. :)

I'll still follow your suggestions and resubmit.

- Evan

[eds, 2010-04-18 19:05:28]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-04-18 19:10:56]

LGTM

leaving for gri

[gri, 2010-04-20 02:06:41]

LGTM

(Provided that we will continue to test both the assembly and portable versions
of code, which appears to be the case).

[gri, 2010-04-20 02:07:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=5adafa4a480d ***

big: Get rid of function pointers and init function

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/929041

Committer: Robert Griesemer <gri@golang.org>