Issue 9285045: Implement named model-path argument for actions. Fix view controller tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9285045: Implement named model-path argument for actions. Fix view controller tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
11 years ago

Reviewers:
arv

CC:
mdv-reviews_googlegroups.com

Base URL:
https://github.com/toolkitchen/mdv.git@v3

Visibility:
Public.

More Reviews

Description

Implement named model-path argument for actions. Fix view controller tests R=arv BUG= Committed: https://github.com/toolkitchen/mdv/commit/d17a9cf

Patch Set 1 #

Total comments: 5

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -9 lines)			Patch
M	examples/util/view_controller.js	View	3 chunks	+15 lines, -8 lines	2 comments	Download
M	examples/util/view_controller_test.html	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	examples/util/view_controller_test.js	View	2 chunks	+32 lines, -1 line	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as rd17a9cf (presubmit successful).

11 years ago (2013-05-07 20:35:59 UTC) #1

arv

11 years ago (2013-05-07 21:26:48 UTC) #2

Message was sent while issue was closed.

LGTM with nits

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller.js
File examples/util/view_controller.js (right):

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller.j...
examples/util/view_controller.js:46: var actionPattern =
/([\w]*)[\s]*:[\s]*([\w]*)(\(([\w\.\$]*)\)){0,1}/;
This regexp is overly complex. [\w]* can be \w*

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller.j...
examples/util/view_controller.js:114: var model = undefined;
var model;

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller_t...
File examples/util/view_controller_test.js (right):

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller_t...
examples/util/view_controller_test.js:94: this.model = { foo: 1, bar: 2 };
{foo: 1, bar: 2}

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller_t...
examples/util/view_controller_test.js:101: }
};

https://codereview.appspot.com/9285045/diff/1/examples/util/view_controller_t...
examples/util/view_controller_test.js:106: '<li
data-action="click:handleClick(bar)">{{ foo }}</li>' +
long line

Expand All Messages | Collapse All Messages