Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 92660044: Remove extra whitespace from messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Rouslan Solomakhin
Modified:
9 years, 11 months ago
CC:
keghani, davinci_google, dbeaumont
Base URL:
https://libaddressinput.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove extra whitespace from messages. This patch removes the extra whitespace from English strings. After this patch lands, Chrome can pull in the strings and start the translation process. R=lararennie@google.com, roubert@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -106 lines) Patch
M cpp/res/messages.grdp View 9 chunks +12 lines, -34 lines 0 comments Download
M cpp/test/localization_test.cc View 11 chunks +83 lines, -72 lines 0 comments Download

Messages

Total messages: 5
Rouslan Solomakhin
Fredrik: PTAL Patch Set 1.
9 years, 11 months ago (2014-05-28 01:31:14 UTC) #1
lararennie
Wow, didn't think it'd care :) LGTM
9 years, 11 months ago (2014-05-28 07:33:22 UTC) #2
roubert (google)
LGTM Keghani is working on fixing GRIT so that normal XML syntax (including spaces, newlines, ...
9 years, 11 months ago (2014-05-28 07:51:05 UTC) #3
Rouslan Solomakhin
On 2014/05/28 07:51:05, roubert wrote: > LGTM > > Keghani is working on fixing GRIT ...
9 years, 11 months ago (2014-05-28 16:27:21 UTC) #4
Rouslan Solomakhin
9 years, 11 months ago (2014-05-28 16:33:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r254 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b