Issue 92610045: New utils/proxy package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92610045: New utils/proxy package.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by frankban

Modified:
9 years, 11 months ago

Reviewers:
mp+220942, fwereade

Visibility:
Public.

Description

New utils/proxy package. Move osenv.Proxy* to utils/proxy. Remove the osenv dependency from utils/apt. https://code.launchpad.net/~frankban/juju-core/utils-proxy/+merge/220942 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : New utils/proxy package. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -160 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	container/lxc/clonetemplate.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	container/lxc/lxc_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/cloudinit.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	environs/config/config.go	View		4 chunks	+14 lines, -13 lines	0 comments	Download
M	environs/config/config_test.go	View		2 chunks	+10 lines, -9 lines	0 comments	Download
M	provider/local/environ.go	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	provider/local/environprovider.go	View		2 chunks	+11 lines, -10 lines	0 comments	Download
M	provider/local/environprovider_test.go	View		13 chunks	+20 lines, -20 lines	0 comments	Download
M	state/api/params/params.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	state/apiserver/provisioner/provisioner_test.go	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/apt/apt.go	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	utils/apt/apt_test.go	View		4 chunks	+13 lines, -13 lines	0 comments	Download
A	utils/proxy/package_test.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	utils/proxy/proxy.go	View		5 chunks	+14 lines, -14 lines	0 comments	Download
M	utils/proxy/proxy_test.go	View	1	10 chunks	+22 lines, -22 lines	0 comments	Download
M	worker/machineenvironmentworker/machineenvironmentworker.go	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	worker/machineenvironmentworker/machineenvironmentworker_test.go	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	worker/uniter/context.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	worker/uniter/context_test.go	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	worker/uniter/export_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	worker/uniter/uniter.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View		4 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM https://codereview.appspot.com/92610045/diff/1/utils/proxy/proxy_test.go File utils/proxy/proxy_test.go (right): https://codereview.appspot.com/92610045/diff/1/utils/proxy/proxy_test.go#newcode17 utils/proxy/proxy_test.go:17: gc.TestingT(t) please put this in a package_test.go, it's ...

9 years, 11 months ago (2014-05-26 12:27:29 UTC) #2

frankban

9 years, 11 months ago (2014-05-26 13:02:32 UTC) #3

Please take a look.

https://codereview.appspot.com/92610045/diff/1/utils/proxy/proxy_test.go
File utils/proxy/proxy_test.go (right):

https://codereview.appspot.com/92610045/diff/1/utils/proxy/proxy_test.go#newc...
utils/proxy/proxy_test.go:17: gc.TestingT(t)
On 2014/05/26 12:27:29, fwereade wrote:
> please put this in a package_test.go, it's way too easy to double/miss them
> otherwise.

Done.

Expand All Messages | Collapse All Messages