Issue 9259043: CPP: Fix compilation error on Clang.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9259043: CPP: Fix compilation error on Clang. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by pliard1

Modified:
12 years, 7 months ago

Reviewers:
pliard, Shaopeng

CC:
lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Fix compilation error on Clang. This fixes a compilation error on Clang due to conflicting declarations (struct vs class) in multiple header files. BUG=http://crbug.com/236272 R=jia.shao.peng@gmail.com Committed: https://code.google.com/p/libphonenumber/source/detail?r=573

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	cpp/src/phonenumbers/callback.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pliard

Thanks Shaopeng! On Tue, May 7, 2013 at 3:05 PM, <jia.shao.peng@gmail.com> wrote: > LGTM > ...

12 years, 7 months ago (2013-05-07 13:06:45 UTC) #3

pliard1

12 years, 7 months ago (2013-05-07 13:08:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r573 (presubmit successful).

Expand All Messages | Collapse All Messages