Issue 9242043: Delete dead code for cloning various types.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9242043: Delete dead code for cloning various types. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Alok Priyadarshi

Modified:
12 years ago

Reviewers:
kbr1, Alan Leung

CC:
angleproject-review_googlegroups.com

Base URL:
https://angleproject.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Delete dead code for cloning various types. R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=2197

Patch Set 1 #

Patch Set 2 : disallow copy and assign #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -149 lines)			Patch
M	src/compiler/SymbolTable.h	View	1	7 chunks	+10 lines, -16 lines	0 comments	Download
M	src/compiler/SymbolTable.cpp	View	1	2 chunks	+0 lines, -76 lines	0 comments	Download
M	src/compiler/Types.h	View	1	3 chunks	+1 line, -57 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Alok Priyadarshi

Committed patchset #2 manually as r2197 (presubmit successful).

12 years ago (2013-05-06 22:22:44 UTC) #3

Alan Leung

12 years ago (2013-05-08 18:26:25 UTC) #4

Message was sent while issue was closed.

On 2013/05/06 22:22:44, Alok Priyadarshi wrote:
> Committed patchset #2 manually as r2197 (presubmit successful).

Hmmm...I have a memory improvement that depends on the copying methods.

Do you think we can resurrect it?

Expand All Messages | Collapse All Messages