Refactor services & templating framework to core

Refactor services & templating framework to core



https://code.launchpad.net/~johnsca/charm-helpers/charm-helpers/+merge/219910

(do not edit description out of merge proposal)

[johnsca, 2014-05-16 22:24:40]

Please take a look.

[johnsca, 2014-05-16 22:29:14]

Please take a look.

[johnsca, 2014-05-16 22:41:41]

Please take a look.

[johnsca, 2014-05-16 23:29:15]

Please take a look.

[benjamin.saller, 2014-05-19 18:28:35]

LGTM w/minors

While not a huge issue, I really would like something better done with the
chownr method. Still ok with a shell out there.
Thanks for this, feel free to land even if all you decide to do here is change
Exception to OSError, but if you'd like me to look at the change again, happy
to.

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/contrib/cloud...
File charmhelpers/contrib/cloudfoundry/contexts.py (right):

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/contrib/cloud...
charmhelpers/contrib/cloudfoundry/contexts.py:38: ctx['db']['port'] = '3306'
s/'db'/self.interface/ on both lines

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/core/host.py
File charmhelpers/core/host.py (right):

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/core/host.py#...
charmhelpers/core/host.py:333: if fatal:
This means that something could go wrong and we continue blindly. I don't think
this is what we want. If nothing else we'd only want to catch errors related to
things like symbolic links here and not things like the path doesn't exist
(maybe an upstart job is modifying the filesytem as well for example) which
Exception will catch.

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/core/services.py
File charmhelpers/core/services.py (right):

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/core/services...
charmhelpers/core/services.py:53: manager_type = service.get('type',
UpstartService)
Thanks for adding this, I think this is a good solution.

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/core/templati...
File charmhelpers/core/templating.py (right):

https://codereview.appspot.com/92420046/diff/60001/charmhelpers/core/templati...
charmhelpers/core/templating.py:7: LOADER = None
No longer used? I think we can remove it

[johnsca, 2014-05-20 22:20:02]

*** Submitted:

Refactor services & templating framework to core

(Forgot to use lbox on this one; my bad.)