Issue 92400045: Save the number of corrupt ranges that has been reported in the error info struct.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92400045: Save the number of corrupt ranges that has been reported in the error info struct. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by Sébastien Marchand

Modified:
11 years, 2 months ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Save the number of corrupt ranges that has been reported in the error info struct. BUG= R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2155

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	syzygy/agent/asan/asan_runtime.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

chrisha

lgtm https://codereview.appspot.com/92400045/diff/1/syzygy/agent/asan/asan_runtime.cc File syzygy/agent/asan/asan_runtime.cc (right): https://codereview.appspot.com/92400045/diff/1/syzygy/agent/asan/asan_runtime.cc#newcode585 syzygy/agent/asan/asan_runtime.cc:585: error_info->corrupt_ranges_reported = range_count; Aha! Knew there was a ...

11 years, 2 months ago (2014-05-16 19:21:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r2155.

Expand All Messages | Collapse All Messages