Issue 9239043: Cleanup after https://github.com/toolkitchen/mdv/commit/7f93f760bf7db60ee7c31cb8ab3d2c31eda16064

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9239043: Cleanup after https://github.com/toolkitchen/mdv/commit/7f93f760bf7db60ee7c31cb8ab3d2c31eda16064 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
11 years ago

Reviewers:
arv

CC:
mdv-reviews_googlegroups.com

Base URL:
https://github.com/toolkitchen/mdv.git@v3

Visibility:
Public.

More Reviews

Description

Cleanup after https://github.com/toolkitchen/mdv/commit/7f93f760bf7db60ee7c31cb8ab3d2c31eda16064 R=arv BUG= Committed: https://github.com/toolkitchen/mdv/commit/502004c

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/template_element.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/node_bindings.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r502004c (presubmit successful).

11 years ago (2013-05-06 20:10:53 UTC) #1

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages