Issue 9236043: Always use DoubleWeakMap on Firefox; optimize.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9236043: Always use DoubleWeakMap on Firefox; optimize. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by kpreid2

Modified:
12 years, 10 months ago

Reviewers:
felix8a, MarkM

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

* Due to our previous detection strategy not catching Firefox 22.0a2, always assume host WeakMap is broken on Firefox. Fixes <https://code.google.com/p/google-caja/issues/detail?id=1704>. * DoubleWeakMap avoids using an emulated WeakMap until it meets a problematic key. * Additional comments on what DoubleWeakMap is doing. * Test framework: boolean asserts receiving a non-boolean argument report the comment to help identify the assert. @r5402

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -21 lines)			Patch
	M	src/com/google/caja/ses/WeakMap.js	View		3 chunks	+39 lines, -18 lines	0 comments	Download
	M	third_party/js/jsunit/2.2/jsUnitCore.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

FWIW, LGTM

Expand All Messages | Collapse All Messages