Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(914)

Issue 9223045: Refactor class to represent structure. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Alok Priyadarshi
Modified:
10 years, 11 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Refactor class to represent structure. We had a TTypeLine to represent a structure field, which simply encapsulated a TType and line number. The line number was only used during parsing for error reporting. There is no need to store a line number because it is already available in the parser token. TEST=WebGL conformance tests R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=2198

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -328 lines) Patch
M src/compiler/Intermediate.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/OutputGLSLBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/SymbolTable.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/Types.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler/VariableInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/glslang.y View 11 chunks +27 lines, -28 lines 2 comments Download
M src/compiler/glslang_tab.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 34 chunks +224 lines, -266 lines 0 comments Download

Messages

Total messages: 5
Alok Priyadarshi
10 years, 11 months ago (2013-05-07 17:26:08 UTC) #1
kbr1
https://codereview.appspot.com/9223045/diff/1/src/compiler/glslang.y File src/compiler/glslang.y (right): https://codereview.appspot.com/9223045/diff/1/src/compiler/glslang.y#newcode1729 src/compiler/glslang.y:1729: context->error($2.line, "duplicate field name in structure:", "struct", field->getFieldName().c_str()); Does ...
10 years, 11 months ago (2013-05-07 18:17:40 UTC) #2
Alok Priyadarshi
https://codereview.appspot.com/9223045/diff/1/src/compiler/glslang.y File src/compiler/glslang.y (right): https://codereview.appspot.com/9223045/diff/1/src/compiler/glslang.y#newcode1729 src/compiler/glslang.y:1729: context->error($2.line, "duplicate field name in structure:", "struct", field->getFieldName().c_str()); It ...
10 years, 11 months ago (2013-05-07 19:44:22 UTC) #3
kbr1
OK. LGTM
10 years, 11 months ago (2013-05-07 20:00:00 UTC) #4
Alok Priyadarshi
10 years, 11 months ago (2013-05-07 20:23:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r2198 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b