Issue 9215046: CPP: Make use of alternate format controlled at compile time.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9215046: CPP: Make use of alternate format controlled at compile time. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by pliard1

Modified:
11 years ago

Reviewers:
pliard, Shaopeng

CC:
lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Make use of alternate format controlled at compile time. This is needed to use a recent revision of libphonenumber in Chromium without building with alternate formats. BUG=http://crbug.com/236272 R=jia.shao.peng@gmail.com Committed: https://code.google.com/p/libphonenumber/source/detail?r=572

Patch Set 1 #

Patch Set 2 : Update README #

Patch Set 3 : Update CMakeLists.txt #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -18 lines)			Patch
M	cpp/CMakeLists.txt	View	1 2	5 chunks	+24 lines, -11 lines	0 comments	Download
M	cpp/README	View	1	1 chunk	+9 lines, -7 lines	0 comments	Download
M	cpp/src/phonenumbers/phonenumbermatcher.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pliard

Thanks Shaopeng! On Tue, May 7, 2013 at 2:55 PM, <jia.shao.peng@gmail.com> wrote: > LGTM > ...

11 years ago (2013-05-07 12:59:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r572 (presubmit successful).

Expand All Messages | Collapse All Messages