Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(266)

Issue 92041: Enable input.blur() in domita (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by felix8a
Modified:
16 years, 10 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. domita has methods for focus() and blur(), but doesn't make blur() callable. This change makes blur() callable. 2. DomitaTest didn't clean up after a test failure. A test failure would make subsequent tests fail to start. This change adds cleanup.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Enable input.blur() in domita #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M src/com/google/caja/plugin/domita.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/DomitaTest.java View 1 3 chunks +10 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4
felix8a
16 years, 11 months ago (2009-07-06 23:54:45 UTC) #1
ihab.awad
http://codereview.appspot.com/92041/diff/1/4 File src/com/google/caja/plugin/domita.js (right): http://codereview.appspot.com/92041/diff/1/4#newcode2530 Line 2530: ['getValue', 'setValue', 'focus', 'blur', eep! Thanks! http://codereview.appspot.com/92041/diff/1/3 File ...
16 years, 11 months ago (2009-07-08 05:53:09 UTC) #2
felix8a
16 years, 11 months ago (2009-07-08 11:23:34 UTC) #3
ihab.awad
16 years, 11 months ago (2009-07-08 15:49:38 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b