Issue 91770043: Dont path a path object into PolymerExpressions.getBinding

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91770043: Dont path a path object into PolymerExpressions.getBinding (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
11 years ago

Reviewers:
sorvell, sjmiles

Base URL:
git@github.com:Polymer/polymer-dev.git@master

Visibility:
Public.

More Reviews

Description

Dont path a path object into PolymerExpressions.getBinding https://codereview.appspot.com/95740044/ broken PolymerExpressions by handing in a Path object rather than the pathString. R=sorvell BUG= Committed: https://github.com/Polymer/polymer-dev/commit/d52a288

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/declaration/mdv.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

rafaelw

11 years ago (2014-04-24 18:19:43 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as rd52a288 (presubmit successful).

Expand All Messages | Collapse All Messages