Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(360)

Issue 9162043: CPP: Make r570 compile in Chromium. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by pliard1
Modified:
7 years, 5 months ago
Reviewers:
Shaopeng
CC:
lararennie
Base URL:
https://libphonenumber.googlecode.com/svn/trunk
Visibility:
Public.

Description

CPP: Make r570 compile in Chromium. This CL ensures that: - All declarations in headers are made in the i18n::phonenumbers namespace. - All USE flags/macros are prefixed with I18N_PHONENUMBERS_ to avoid name clashes. - All the code in base/ is actually used (by deleting unused code). - Outdated occurrences of USE_GOOGLE_BASE don't exist anymore. - Logging in PhoneNumberUtil is disabled by default (in production). However it can be enabled by calling PhoneNumberUtil::SetLogger() as it is now done during testing. BUG=http://crbug.com/236272 R=jia.shao.peng@gmail.com Committed: https://code.google.com/p/libphonenumber/source/detail?r=571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -212 lines) Patch
M cpp/CMakeLists.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M cpp/src/phonenumbers/base/basictypes.h View 6 chunks +13 lines, -94 lines 0 comments Download
M cpp/src/phonenumbers/base/memory/scoped_ptr.h View 10 chunks +10 lines, -19 lines 0 comments Download
M cpp/src/phonenumbers/base/thread_checker.h View 3 chunks +5 lines, -4 lines 0 comments Download
M cpp/src/phonenumbers/default_logger.h View 3 chunks +3 lines, -26 lines 0 comments Download
M cpp/src/phonenumbers/default_logger.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M cpp/src/phonenumbers/phonenumbermatcher.cc View 6 chunks +10 lines, -31 lines 0 comments Download
M cpp/src/phonenumbers/phonenumberutil.h View 4 chunks +6 lines, -11 lines 0 comments Download
M cpp/src/phonenumbers/phonenumberutil.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cpp/src/phonenumbers/regexp_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/regexp_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/regexp_factory.h View 1 chunk +7 lines, -7 lines 0 comments Download
M cpp/src/phonenumbers/utf/unicodetext.h View 2 chunks +6 lines, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/unicodetext.cc View 2 chunks +6 lines, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/unilib.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cpp/src/phonenumbers/utf/unilib.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M cpp/test/phonenumbers/asyoutypeformatter_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cpp/test/phonenumbers/phonenumbermatcher_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cpp/test/phonenumbers/phonenumberutil_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cpp/test/phonenumbers/shortnumberutil_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cpp/test/phonenumbers/utf/unicodetext_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
pliard1
7 years, 5 months ago (2013-05-03 12:22:52 UTC) #1
Shaopeng
On 2013/05/03 12:22:52, pliard1 wrote: Looks like you also need to update the README file ...
7 years, 5 months ago (2013-05-03 13:36:23 UTC) #2
pliard1
On 2013/05/03 13:36:23, Shaopeng wrote: > On 2013/05/03 12:22:52, pliard1 wrote: > > Looks like ...
7 years, 5 months ago (2013-05-03 13:39:24 UTC) #3
Shaopeng
LGTM. On 2013/05/03 13:39:24, pliard1 wrote: > On 2013/05/03 13:36:23, Shaopeng wrote: > > On ...
7 years, 5 months ago (2013-05-03 13:46:47 UTC) #4
pliard1
On 2013/05/03 13:46:47, Shaopeng wrote: > LGTM. > > On 2013/05/03 13:39:24, pliard1 wrote: > ...
7 years, 5 months ago (2013-05-03 13:47:30 UTC) #5
pliard1
7 years, 5 months ago (2013-05-03 13:49:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r571 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b