Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(406)

Issue 9152043: We don't need to keep the param variable around for function prototypes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Alan Leung Chromium
Modified:
10 years, 10 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

We don't need to keep the param variable around for function prototypes. Saves 20% memory for global symbol initialization

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M compiler/glslang.y View 1 chunk +2 lines, -2 lines 3 comments Download
M compiler/glslang_tab.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9
Alan Leung Chromium
10 years, 11 months ago (2013-05-02 23:31:15 UTC) #1
nicolas%transgaming.com
It looks like you have a different version of Flex. I noticed that Cygwin has ...
10 years, 11 months ago (2013-05-03 15:01:43 UTC) #2
Alan Leung Chromium
On 2013/05/03 15:01:43, nicolas%transgaming.com wrote: > It looks like you have a different version of ...
10 years, 11 months ago (2013-05-03 18:02:11 UTC) #3
kbr1
Please regenerate the grammar on Mac OS. Unfortunately, it seems that only Apple's versions of ...
10 years, 11 months ago (2013-05-03 19:27:07 UTC) #4
Alan Leung Chromium
On 2013/05/03 19:27:07, kbr1 wrote: > Please regenerate the grammar on Mac OS. Unfortunately, it ...
10 years, 11 months ago (2013-05-03 22:18:23 UTC) #5
Alok Priyadarshi
lgtm Since you are only editing .y file, you can get away with regenerating the ...
10 years, 10 months ago (2013-05-06 16:38:05 UTC) #6
Alan Leung Chromium
I don't think I have commit access to the project? What I am suppose to ...
10 years, 10 months ago (2013-05-06 18:53:16 UTC) #7
Alok Priyadarshi
I will land this patch. Nicolas: Could you provide commit access for future? https://codereview.appspot.com/9152043/diff/10001/compiler/glslang.y File ...
10 years, 10 months ago (2013-05-06 18:58:46 UTC) #8
Alok Priyadarshi
10 years, 10 months ago (2013-05-06 19:15:43 UTC) #9
Committed in r2196. Please close this issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b