Issue 915041: code review 915041: ld: Add DOS stub to PE binaries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 915041: code review 915041: ld: Add DOS stub to PE binaries (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by eds

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

ld: Add DOS stub to PE binaries

Patch Set 1 #

Patch Set 2 : code review 915041: ld: Add DOS stub to PE binaries #

Patch Set 3 : code review 915041: ld: Add DOS stub to PE binaries #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	src/cmd/ld/pe.c	View	1 2	2 chunks	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

eds

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 11 months ago (2010-04-13 01:33:41 UTC) #1

rsc

looks good. i think you can use write(cout, dosstub, sizeof dosstub); instead of the loop. ...

14 years, 11 months ago (2010-04-13 01:56:30 UTC) #2

eds

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-04-13 02:20:54 UTC) #3

rsc

14 years, 11 months ago (2010-04-13 23:13:56 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=8e2dea8c2e25 ***

8l: add DOS stub to PE binaries

R=rsc
CC=golang-dev
http://codereview.appspot.com/915041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages