Issue 91460046: Refactored to use refactored charm-helpers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91460046: Refactored to use refactored charm-helpers

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by johnsca

Modified:
11 years, 1 month ago

Reviewers:
benjamin.saller, mp+219913

Visibility:
Public.

Description

Refactored to use refactored charm-helpers https://code.launchpad.net/~johnsca/charms/trusty/cf-dea/refactor/+merge/219913 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -139 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/contexts.py	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	hooks/charmhelpers/core/host.py	View	3 chunks	+27 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/core/services.py	View	4 chunks	+33 lines, -31 lines	0 comments	Download
M	hooks/charmhelpers/core/templating.py	View	3 chunks	+79 lines, -85 lines	0 comments	Download
M	hooks/hooks.py	View	3 chunks	+6 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnsca

11 years, 1 month ago (2014-05-20 22:17:13 UTC) #3

On 2014/05/19 18:52:51, benjamin.saller wrote:
> LGTM, thanks

*** Submitted:

Refactored to use refactored charm-helpers

(I had some issues with merging this, due to the revert commit, so submitting it
manually instead of with lbox.)

Expand All Messages | Collapse All Messages