Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(287)

Issue 91450047: Fix incorrect feature tests in SES and Domado. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by kpreid_google
Modified:
11 years, 9 months ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes the following: inTestFrame used for repairES5 repairs http://code.google.com/p/google-caja/issues/detail?id=1917 test_TYPED_ARRAYS_THROW_DOMEXCEPTION http://code.google.com/p/google-caja/issues/detail?id=1918 Distinguishing between direct-proxies and old style proxies http://code.google.com/p/google-caja/issues/detail?id=1919 @r5685

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix incorrect feature tests in SES and Domado. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 chunk +4 lines, -1 line 0 comments Download
M src/com/google/caja/ses/repairES5.js View 1 2 chunks +8 lines, -3 lines 0 comments Download
M src/com/google/caja/ses/startSES.js View 1 1 chunk +6 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/browser-test-case.js View 1 1 chunk +7 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
kpreid_google
11 years, 9 months ago (2014-05-15 19:12:17 UTC) #1
MarkM
https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js#newcode2574 src/com/google/caja/ses/repairES5.js:2574: if (typeof global.DataView === 'undefined') { return false; } ...
11 years, 9 months ago (2014-05-15 20:51:51 UTC) #2
kpreid_google
Fixes the following: inTestFrame used for repairES5 repairs http://code.google.com/p/google-caja/issues/detail?id=1917 test_TYPED_ARRAYS_THROW_DOMEXCEPTION http://code.google.com/p/google-caja/issues/detail?id=1918 Distinguishing between direct-proxies and ...
11 years, 9 months ago (2014-05-15 23:42:32 UTC) #3
kpreid_google
https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js#newcode2574 src/com/google/caja/ses/repairES5.js:2574: if (typeof global.DataView === 'undefined') { return false; } ...
11 years, 9 months ago (2014-05-15 23:45:24 UTC) #4
MarkM
11 years, 9 months ago (2014-05-16 03:00:44 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b