Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 912043: code review 912043: Modern gccs understand -pthread. It should be given to ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by Stefano Rivera
Modified:
15 years, 1 month ago
Reviewers:
CC:
rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

Modern gccs understand -pthread. It should be given to both the pre-processor and the linker. Fixes issue 14.

Patch Set 1 #

Patch Set 2 : code review 912043: Modern gccs understand -pthread. It should be given to ... #

Patch Set 3 : code review 912043: Modern gccs understand -pthread. It should be given to ... #

Patch Set 4 : code review 912043: Modern gccs understand -pthread. It should be given to ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Makefile View 3 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5
Stefano Rivera
Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change.
15 years, 1 month ago (2010-04-16 08:54:46 UTC) #1
Stefano Rivera
Hello rsc (cc: re2-dev@googlegroups.com), Please take another look.
15 years, 1 month ago (2010-04-16 08:55:32 UTC) #2
Stefano Rivera
Hello rsc (cc: re2-dev@googlegroups.com), Please take another look.
15 years, 1 month ago (2010-04-23 14:21:06 UTC) #3
rsc1
LGTM But I think that -pthread belongs on ordinary CXXFLAGS. If someone wants to override ...
15 years, 1 month ago (2010-04-30 06:14:58 UTC) #4
rsc
15 years, 1 month ago (2010-04-30 06:15:21 UTC) #5
*** Submitted as http://code.google.com/p/re2/source/detail?r=0b22cb457129 ***

Modern gccs understand -pthread. It should be given to both the
pre-processor and the linker.

Fixes issue 14.

R=rsc
CC=re2-dev
http://codereview.appspot.com/912043

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b