Issue 912043: code review 912043: Modern gccs understand -pthread. It should be given to ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 912043: code review 912043: Modern gccs understand -pthread. It should be given to ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by Stefano Rivera

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

Modern gccs understand -pthread. It should be given to both the pre-processor and the linker. Fixes issue 14.

Patch Set 1 #

Patch Set 2 : code review 912043: Modern gccs understand -pthread. It should be given to ... #

Patch Set 3 : code review 912043: Modern gccs understand -pthread. It should be given to ... #

Patch Set 4 : code review 912043: Modern gccs understand -pthread. It should be given to ... #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	Makefile	View	3	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Stefano Rivera

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-04-16 08:54:46 UTC) #1

Stefano Rivera

Hello rsc (cc: re2-dev@googlegroups.com), Please take another look.

15 years, 2 months ago (2010-04-16 08:55:32 UTC) #2

Stefano Rivera

Hello rsc (cc: re2-dev@googlegroups.com), Please take another look.

15 years, 2 months ago (2010-04-23 14:21:06 UTC) #3

rsc1

LGTM But I think that -pthread belongs on ordinary CXXFLAGS. If someone wants to override ...

15 years, 1 month ago (2010-04-30 06:14:58 UTC) #4

rsc

15 years, 1 month ago (2010-04-30 06:15:21 UTC) #5

*** Submitted as http://code.google.com/p/re2/source/detail?r=0b22cb457129 ***

Modern gccs understand -pthread. It should be given to both the
pre-processor and the linker.

Fixes issue 14.

R=rsc
CC=re2-dev
http://codereview.appspot.com/912043

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages