Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5317)

Issue 91140045: Include annotations in bundle search results.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by bac
Modified:
9 years, 12 months ago
Reviewers:
j.c.sackett, mp+218520
Visibility:
Public.

Description

Include annotations in bundle search results. The previous attempt at this problem was flawed in that API call for getting bundles directly pulls from Mongo while search?text= and search/interesting get results from ElasticSearch. QA: Load up some bundles with annotations: bin/ingest-queued --prefix="~charmers/charms/precise/ntp" bin/ingest-queued --prefix="~bac" Change juju-gui to point to locally running charmworld: diff --git a/app/config-debug.js b/app/config-debug.js index 39daca6..f2c86b6 100644 --- a/app/config-debug.js +++ b/app/config-debug.js @@ -32,7 +32,10 @@ var juju_config = { // These are the main application config items used and passed down into all // SubApps. consoleEnabled: true, + //charmworldURL: 'https://manage.jujucharms.com/', + charmworldURL: 'http://127.0.0.1:2464/', Run charmworld and juju-gui. In the GUI wait for the initial results to load. These are the Featured charms and bundles. Select the rails-scalable bundle. Note the layout in the inspector. Close the inspector and then drag the bundle (using the name not the icon) to the canvas. Note that the layout is the same as the preview. https://code.launchpad.net/~bac/charmworld/annotation-dos/+merge/218520 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -10 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/views/api/__init__.py View 4 chunks +7 lines, -6 lines 0 comments Download
M charmworld/views/tests/test_api.py View 4 chunks +68 lines, -4 lines 2 comments Download

Messages

Total messages: 2
bac
Please take a look.
9 years, 12 months ago (2014-05-06 22:03:39 UTC) #1
j.c.sackett
9 years, 12 months ago (2014-05-07 13:14:14 UTC) #2
LGTM, with one minor improvement/question.

https://codereview.appspot.com/91140045/diff/1/charmworld/views/tests/test_ap...
File charmworld/views/tests/test_api.py (right):

https://codereview.appspot.com/91140045/diff/1/charmworld/views/tests/test_ap...
charmworld/views/tests/test_api.py:1786: services['charm'].update(extra_data)
Is there any reason to not just declare services with annotations already in
charm, rather than calling update on it?

https://codereview.appspot.com/91140045/diff/1/charmworld/views/tests/test_ap...
charmworld/views/tests/test_api.py:1821: services['charm'].update(extra_data)
Same question as above.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b