Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 91119: New instrument name positioning in Scheme. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by Neil Puttock
Modified:
9 years, 9 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New instrument name positioning in Scheme. * remove x/y positioning from print callback to separate X- and Y-offset callbacks * add x-offset calculation for system start delimeter extents so all instrument names in a system are aligned correctly based on self-alignment-X * use 'when from left-bound instead of get_break_index () to determine which text to print; this fixes incorrect indentation and text for shortInstrumentName overrides (Issue #452) * remove acknowledger for system-start-text from system-start-delimiter-engraver.cc * remove system-start-text.cc * add system-start-text-interface to define-grob-interfaces.scm * add library functions used by new callbacks to lily-library.scm and output-lib.scm

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -177 lines) Patch
M input/lsr/incipit.ly View 3 chunks +37 lines, -34 lines 0 comments Download
A input/new/incipit.ly View 1 chunk +273 lines, -0 lines 0 comments Download
M input/regression/incipit.ly View 2 chunks +2 lines, -4 lines 0 comments Download
M lily/system-start-delimiter-engraver.cc View 4 chunks +5 lines, -16 lines 0 comments Download
M lily/system-start-text.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +5 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +3 lines, -2 lines 0 comments Download
M scm/lily-library.scm View 3 chunks +10 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 2 chunks +92 lines, -0 lines 1 comment Download

Messages

Total messages: 2
joeneeman
Just one corner case, otherwise lgtm http://codereview.appspot.com/91119/diff/1/10 File scm/output-lib.scm (right): http://codereview.appspot.com/91119/diff/1/10#newcode833 Line 833: (interval-center extent)))) ...
9 years, 10 months ago (2009-07-16 05:52:35 UTC) #1
Neil Puttock
9 years, 10 months ago (2009-07-16 22:51:26 UTC) #2
On 2009/07/16 05:52:35, joeneeman wrote:
> Just one corner case, otherwise lgtm

Thanks, Joe.

I'll add a convert-ly rule for ly:system-start-text::print, a regtest and NEWS
entry before pushing.
 
> 
> http://codereview.appspot.com/91119/diff/1/10
> File scm/output-lib.scm (right):
> 
> http://codereview.appspot.com/91119/diff/1/10#newcode833
> Line 833: (interval-center extent))))
> If (not (pair? live-elts)) then (interval-center extent) will be NaN, instead
of
> 0 which would be more sensible.

That's caught by interval-center, since it returns 0.0 for empty intervals.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b