Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 91117: fix onfocus/onblur, and make DomitaTest more reliable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by felix8a
Modified:
16 years, 10 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1075 1. bridal only attaches to real events if the event name corresponds to an html whitelisted attribute '*:onfoo'. focus/blur is whitelisted for specific tags, not for '*', so the whitelist check fails, and no handler gets attached. this change fixes that. 2. DomitaTest is prone to false positives because the string 'all tests passed' gets added to the title before all tests finish running. this change fixes that.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -52 lines) Patch
M src/com/google/caja/plugin/bridal.js View 3 chunks +12 lines, -7 lines 0 comments Download
M tests/com/google/caja/plugin/DomitaTest.java View 3 chunks +18 lines, -8 lines 1 comment Download
M tests/com/google/caja/plugin/domita_test.html View 3 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 9 chunks +67 lines, -14 lines 1 comment Download
M tests/com/google/caja/plugin/jsunit.js View 5 chunks +48 lines, -15 lines 1 comment Download

Messages

Total messages: 3
felix8a
16 years, 10 months ago (2009-07-14 22:10:53 UTC) #1
ihab.awad
LGTM++ See comments. http://codereview.appspot.com/91117/diff/1/5 File tests/com/google/caja/plugin/DomitaTest.java (right): http://codereview.appspot.com/91117/diff/1/5#newcode128 Line 128: assertTrue("Too many wait rounds.", waitRounds ...
16 years, 10 months ago (2009-07-16 18:38:50 UTC) #2
felix8a
16 years, 10 months ago (2009-07-16 19:28:29 UTC) #3
On 2009/07/16 18:38:50, ihab.awad wrote:
> LGTM++
> 
> See comments.
> 
> http://codereview.appspot.com/91117/diff/1/5
> File tests/com/google/caja/plugin/DomitaTest.java (right):
> 
> http://codereview.appspot.com/91117/diff/1/5#newcode128
> Line 128: assertTrue("Too many wait rounds.", waitRounds < waitRoundLimit);
> I would suggest formatting the "clicking" and "waiting" loops so they have
> identical line spacing, etc., to highlight their similarity.

ok

> http://codereview.appspot.com/91117/diff/1/4
> File tests/com/google/caja/plugin/domita_test_untrusted.html (right):
> 
> http://codereview.appspot.com/91117/diff/1/4#newcode2387
> Line 2387: false);
> Please indent above lines 2 more spaces. Same elsewhere.

ok

> http://codereview.appspot.com/91117/diff/1/3
> File tests/com/google/caja/plugin/jsunit.js (right):
> 
> http://codereview.appspot.com/91117/diff/1/3#newcode131
> Line 131: console.log('FAIL: ' + testName);
> Why not also updateStatus() on failure, since you updateStatus() on passing?

ah, right.  forgot to do that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b