Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(259)

Issue 91075: Improvements for the SVG backend (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Patrick McCarty
Modified:
9 years, 11 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Improvements for the SVG backend * Use ly:format instead for rounding page dimensions; it gives more accurate results. * Use the "viewBox" attribute for <svg> to scale the output instead of <g scale="">...</g> * Remove other superfluous grouping tags * Only match the elements of a PangoFontDescription that LilyPond is capable of matching. * Store the attributes for a PangoFontDescription in an alist to filter unwanted attributes. * Ignore the "style" of a font smob; it cannot be used to match the correct embedded SVG font. * The fill of "round-filled-box" should be "currentColor"

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revisions according to Joe's first comment #

Patch Set 3 : Address Joe's second comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -54 lines) Patch
M scm/framework-svg.scm View 4 chunks +7 lines, -12 lines 0 comments Download
M scm/output-svg.scm View 1 2 2 chunks +38 lines, -42 lines 0 comments Download

Messages

Total messages: 3
joeneeman
http://codereview.appspot.com/91075/diff/1/3 File scm/output-svg.scm (right): http://codereview.appspot.com/91075/diff/1/3#newcode140 Line 140: (match:substring match 1))) Why not just (set-attribute 'font-weight ...
9 years, 11 months ago (2009-07-07 18:32:44 UTC) #1
Patrick McCarty
Thanks for your review, Joe. On 2009/07/07 18:32:44, joeneeman wrote: > http://codereview.appspot.com/91075/diff/1/3 > File scm/output-svg.scm ...
9 years, 11 months ago (2009-07-07 21:10:54 UTC) #2
Patrick McCarty
9 years, 11 months ago (2009-07-07 21:22:41 UTC) #3
On 2009/07/07 21:10:54, Patrick McCarty wrote:
> 
> > http://codereview.appspot.com/91075/diff/1/3#newcode155
> > Line 155: (set! alist (reverse alist))
> > You can use reverse! here
> 
> Oddly, this did not work.  I tried
> 
>   (reverse! alist)
>   (apply entity 'text expr alist)))

Never mind.  Patch Set 3 fixes it.  Okay to apply?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b