Issue 9086045: fix text binding to undefined

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9086045: fix text binding to undefined (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
10 years, 8 months ago

Reviewers:
arv, erik.arvidsson

CC:
mdv-reviews_googlegroups.com

Base URL:
https://github.com/toolkitchen/mdv.git@master

Visibility:
Public.

More Reviews

Description

fix text binding to undefined R=arv BUG= Committed: https://github.com/toolkitchen/mdv/commit/7f93f76

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -17 lines)			Patch
	M	src/template_element.js	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	tests/node_bindings.js	View		3 chunks	+2 lines, -16 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r7f93f76 (presubmit successful).

11 years ago (2013-05-02 00:55:51 UTC) #1

arv

11 years ago (2013-05-02 15:50:44 UTC) #2

Message was sent while issue was closed.

LGTM

https://codereview.appspot.com/9086045/diff/1/src/template_element.js
File src/template_element.js (right):

https://codereview.appspot.com/9086045/diff/1/src/template_element.js#newcode63
src/template_element.js:63: textNode.data = String(value === undefined ? '' :
value);
textNode.data = value === undefined ? '' : String(value);

would have been a bit clearer

https://codereview.appspot.com/9086045/diff/1/tests/node_bindings.js
File tests/node_bindings.js (right):

https://codereview.appspot.com/9086045/diff/1/tests/node_bindings.js#newcode76
tests/node_bindings.js:76: assert.isTrue(element.hasAttribute('hidden'));
tab

Expand All Messages | Collapse All Messages