Issue 9081043: Defalut triggers key is changed to <Super>space.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9081043: Defalut triggers key is changed to <Super>space. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by fujiwara

Modified:
10 years, 8 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Defalut triggers key is changed to <Super>space. We have been used <Control>space as the default triggers key. GNOME3 and Windows7 applied <Super>space as the default trigger key and IBus follows it for the consistent key between desktops. BUG=RH#953404

Patch Set 1 #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	data/ibus.schemas.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	setup/main.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gtk3/panel.vala	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

On 2013/05/01 14:49:33, fujiwara wrote: I think change it to <Supper>Space is OK to me. ...

10 years, 12 months ago (2013-05-01 15:14:40 UTC) #2

fujiwara

On 2013/05/01 15:14:40, Peng wrote: > On 2013/05/01 14:49:33, fujiwara wrote: > > I think ...

10 years, 12 months ago (2013-05-03 02:05:29 UTC) #3

Peng

10 years, 12 months ago (2013-05-03 16:28:09 UTC) #4

On 2013/05/03 02:05:29, fujiwara wrote:
> On 2013/05/01 15:14:40, Peng wrote:
> > On 2013/05/01 14:49:33, fujiwara wrote:
> > 
> > I think change it to <Supper>Space is OK to me. But I am thinking how to let
> > user know this change. Otherwise we will get a lot complain about hotkey
does
> > not work.
> 
> How about another patch adding a configure option to customize ibus.schemas.in
> later?
> When ibus 1.5.3 is released, probably we can inform of this.

LGTM. I think we should find a good way to let end-user know it.

Expand All Messages | Collapse All Messages