Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8369)

Issue 9078046: Refactor location tracking. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Alok Priyadarshi
Modified:
10 years, 11 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Refactor location tracking. R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=2202

Patch Set 1 #

Patch Set 2 : rebase with TOT #

Patch Set 3 : Fixed locations for aggregate nodes #

Total comments: 16

Patch Set 4 : 64-bit clean glslang_lex.cpp #

Patch Set 5 : Initialized TIntermNode::line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1049 lines, -936 lines) Patch
M src/compiler/Common.h View 1 chunk +6 lines, -18 lines 0 comments Download
M src/compiler/Compiler.cpp View 1 4 chunks +12 lines, -6 lines 0 comments Download
M src/compiler/Diagnostics.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/InfoSink.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/InfoSink.cpp View 1 2 chunks +10 lines, -15 lines 0 comments Download
M src/compiler/Intermediate.cpp View 1 37 chunks +40 lines, -56 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 10 chunks +14 lines, -14 lines 0 comments Download
M src/compiler/ParseHelper.h View 1 2 chunks +38 lines, -38 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 1 37 chunks +42 lines, -40 lines 0 comments Download
M src/compiler/Types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/glslang.l View 5 chunks +10 lines, -12 lines 0 comments Download
M src/compiler/glslang.y View 1 2 78 chunks +330 lines, -312 lines 0 comments Download
M src/compiler/glslang_lex.cpp View 1 2 3 10 chunks +33 lines, -13 lines 0 comments Download
M src/compiler/glslang_tab.h View 4 chunks +22 lines, -2 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 1 2 165 chunks +434 lines, -357 lines 0 comments Download
M src/compiler/intermOut.cpp View 1 4 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/intermediate.h View 1 2 3 4 5 chunks +10 lines, -9 lines 0 comments Download
M src/compiler/localintermediate.h View 1 chunk +20 lines, -21 lines 0 comments Download
M src/compiler/parseConst.cpp View 1 7 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/timing/RestrictVertexShaderTiming.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Alok Priyadarshi
Sorry about the big patch. Do not worry about the generated files. I will re-generate ...
10 years, 11 months ago (2013-05-08 22:48:31 UTC) #1
kbr1
That's OK. LGTM with a few questions. https://codereview.appspot.com/9078046/diff/7001/src/compiler/glslang.y File src/compiler/glslang.y (right): https://codereview.appspot.com/9078046/diff/7001/src/compiler/glslang.y#newcode526 src/compiler/glslang.y:526: $$ = ...
10 years, 11 months ago (2013-05-08 23:49:52 UTC) #2
Alok Priyadarshi
Thanks for the thorough review. https://codereview.appspot.com/9078046/diff/7001/src/compiler/glslang.y File src/compiler/glslang.y (right): https://codereview.appspot.com/9078046/diff/7001/src/compiler/glslang.y#newcode526 src/compiler/glslang.y:526: $$ = context->intermediate.addUnaryMath(op, $1.intermNode, ...
10 years, 11 months ago (2013-05-09 04:03:08 UTC) #3
Alok Priyadarshi
10 years, 11 months ago (2013-05-09 17:54:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r2202 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b