Issue 9077045: more cleanup after view controller args

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9077045: more cleanup after view controller args (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rafaelw

Modified:
11 years ago

Reviewers:
arv

CC:
mdv-reviews_googlegroups.com

Base URL:
https://github.com/toolkitchen/mdv.git@master

Visibility:
Public.

More Reviews

Description

more cleanup after view controller args R=arv BUG= Committed: https://github.com/toolkitchen/mdv/commit/68a880f

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	examples/util/view_controller.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r68a880f (presubmit successful).

11 years ago (2013-05-09 15:51:19 UTC) #1

arv

11 years ago (2013-05-09 16:54:11 UTC) #2

LGTM


On Thu, May 9, 2013 at 11:51 AM, <rafaelw@chromium.org> wrote:

> Reviewers: arv,
>
> Message:
> Committed patchset #1 manually as r68a880f (presubmit successful).
>
> Description:
> more cleanup after view controller args
>
> R=arv
> BUG=
>
> Committed:
https://github.com/**toolkitchen/mdv/commit/68a880f<https://github.com/toolki...
>
> Please review this at
https://codereview.appspot.**com/9077045/<https://codereview.appspot.com/9077...
>
> Affected files:
>   M examples/util/view_controller.**js
>
>
> Index: examples/util/view_controller.**js
> diff --git a/examples/util/view_**controller.js b/examples/util/view_**
> controller.js
> index 5518673a61dab53d144aa00f40d1e5**9a31afa197..**
> ce3173920bba0db77abf5bd6edfca1**ce05b93cca 100644
> --- a/examples/util/view_**controller.js
> +++ b/examples/util/view_**controller.js
> @@ -43,7 +43,7 @@
>
>    var registeredEvents = {};
>
> -  var actionPattern = /(\w*)[\s]*:[\s]*(\w*)(\(([\w\**.\$]*)\)){0,1}/;
> +  var actionPattern = /(\w*)\s*:\s*(\w*)(\(([\w\.\$]***)\)){0,1}/;
>
>    function getAction(node) {
>      if (node.nodeType !== Node.ELEMENT_NODE)
>
>
>


-- 
erik

Expand All Messages | Collapse All Messages