Sandbox import/export w/File DnD support

test/test_sandbox.js

 'use strict';
 
 (function() {
 
   describe('sandbox.ClientConnection', function() {
     var requires = ['juju-env-sandbox', 'json-stringify'];
     var Y, sandboxModule, ClientConnection;
 
     before(function(done) {
       Y = YUI(GlobalConfig).use(requires, function(Y) {
@@ skipping 145 matching lines @@
       assert.throws(
           conn.receive.bind(conn, {response: 42}),
           'INVALID_STATE_ERR : Connection is closed.');
     });
 
   });
 
   describe('sandbox.PyJujuAPI', function() {
     var requires = [
       'juju-env-sandbox', 'juju-tests-utils', 'juju-env-python',
-      'juju-models'];
+      'juju-models', 'promise'];
     var Y, sandboxModule, ClientConnection, PyJujuAPI, environmentsModule,
         state, juju, client, env, utils, cleanups;
 
     this.timeout(2000); // Long timeouts make async failures hard to detect.
 
     before(function(done) {
       Y = YUI(GlobalConfig).use(requires, function(Y) {
         sandboxModule = Y.namespace('juju.environments.sandbox');
         environmentsModule = Y.namespace('juju.environments');
         utils = Y.namespace('juju-tests.utils');
@@ skipping 1185 matching lines @@
           request_id: 99
         };
         client.onmessage = function(received) {
           var parsed = Y.JSON.parse(received.data);
           assert.equal(parsed.result, true);
           done(parsed.error);
         };
         client.open();
         client.send(Y.JSON.stringify(op));
       });
+    });
 
+    /**
+     * Utility method to turn _some_ callback
+     * styled async methods into Promises.
+     * It doesn't this by supplying a simple

[gary.poster, 2013/05/01 19:29:18]

doesn't? :-)

[bcsaller, 2013/05/01 20:47:21]

Oh no I didn't!

+     * adaptor that can handle {error:...}
+     * and {result: ... } returns.
+     *
+     * This callback is appended to any calling arguments
+     *
+     * @method P
+     * @param {Object} context Calling context.
+     * @param {String} methodName name of method on context to invoke.
+     * @param {Arguments} arguments Additional arguments passed
+     *        to resolved method.
+     * @return {Promise} a Y.Promise object.
+     */
+    function P(context, methodName) {
+      var slice = Array.prototype.slice;
+      var args = slice.call(arguments, 2);
+      var method = context[methodName];
+
+      return Y.Promise(function(resolve, reject) {
+        var resultHandler = function(result) {
+          if (result.err || result.error) {
+            reject(result.err || result.error);
+          } else {
+            resolve(result);
+          }
+        };
+
+        args.push(resultHandler);
+        var result = method.apply(context, args);
+        if (result !== undefined) {
+          // The method returned right away.
+          return resultHandler(result);
+        }
+      });
+    }
+
+    it('should support export', function(done) {
+      this.timeout(250);
+
+      client.open();
+      // jshint is insisting on these 'new' prefixes.

[gary.poster, 2013/05/01 19:29:18]

Because of initial capital letter, maybe?  Maybe if you called it promise it
would remove the unnecessary "new" and be a bit easier to read?

[bcsaller, 2013/05/01 20:47:21]

That appears to have been it. Overcome by convention. Thanks.

+      new P(state, 'deploy', 'cs:wordpress')
+       .then(new P(state, 'deploy', 'cs:mysql'))
+       .then(new P(state, 'addRelation', 'wordpress:db', 'mysql:db'))
+       .then(function() {
+            client.onmessage = function(result) {
+              var data = Y.JSON.parse(result.data).result;
+              assert.equal(data.services[0].name, 'wordpress');
+              done();
+            };
+            client.send(Y.JSON.stringify({op: 'exportEnvironment'}));
+          });
+    });
+
+    it('should support import', function(done) {
+      this.timeout(300);
+      var fixture = utils.loadFixture('data/sample-fakebackend.json', false);
+
+      client.onmessage = function() {
+        client.onmessage = function(result) {
+          var data = Y.JSON.parse(result.data).result;
+          assert.isTrue(data);
+
+          // Verify that we can now an find expected entry
+          // in the database.
+          assert.isNotNull(state.db.services.getById('wordpress'));
+
+          var changes = state.nextChanges();
+          // Validate the delta includes imported services.
+          assert.include(changes.services, 'wordpress');
+          assert.include(changes.services, 'mysql');
+          // validate relation was added/updated.
+          assert.include(changes.relations, 'relation-0');
+          done();
+        };
+        client.send(Y.JSON.stringify({op: 'importEnvironment',
+                             envData: fixture}));
+      };
+      client.open();
     });
 
   });
 
 })();