bootstrap: always provider precise and trusty

bootstrap: always provider precise and trusty

Now that we have 2 potential LTS targets, when we bootstrap the local
provider, make sure we upload tools for both of them. That way when
deploying charms, we can successfully deploy all the stable charms.

This addresses bug #1306537, perhaps as a band-aid but I think a
reasonable one.

https://code.launchpad.net/~jameinel/juju-core/1.18-local-trusty-and-precise-1306537/+merge/216888

(do not edit description out of merge proposal)

[jameinel, 2014-04-23 13:53:58]

Please take a look.

[axw, 2014-04-24 00:50:19]

One comment, otherwise LGTM.

https://codereview.appspot.com/90640043/diff/1/cmd/juju/bootstrap.go
File cmd/juju/bootstrap.go (right):

https://codereview.appspot.com/90640043/diff/1/cmd/juju/bootstrap.go#newcode137
cmd/juju/bootstrap.go:137: // If we are going to be forcing the tools, we might
as
Should this be under "if c.UploadTools" below, rather than specific to the local
provider?

[wallyworld, 2014-04-24 02:02:24]

not lgtm since as per my comments i think the correct place to make this change
is elsewhere.

https://codereview.appspot.com/90640043/diff/1/cmd/juju/bootstrap.go
File cmd/juju/bootstrap.go (right):

https://codereview.appspot.com/90640043/diff/1/cmd/juju/bootstrap.go#newcode142
cmd/juju/bootstrap.go:142: }
Actually, this is the wrong place to put this change.
The correct place to make this change is bootstrap.SeriesToUpload() in
environs/bootstrap/synctools.go

This method adds in series from:
- version.Current.Series
- config.LatestLtsSeries()
- cfg.DefaultSeries()

But when LatestLtsSeries() switched to trusty, it broke things on trusty hosts.
I think the correct change is to simply replace config.LatestLtsSeries() with
"precise, trusty". And, as a bonus, there are tests for that.