Issue 90490043: Remove HyBi 08 version protocol support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90490043: Remove HyBi 08 version protocol support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by tyoshino (chromium.org)

Modified:
12 years ago

Reviewers:
Adam Rice

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove HyBi 08 version protocol support R=ricea@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=794

Patch Set 2 : #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -369 lines)			Patch
M	src/mod_pywebsocket/common.py	View		6 chunks	+7 lines, -10 lines	0 comments	Download
M	src/mod_pywebsocket/extensions.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mod_pywebsocket/handshake/hybi.py	View		5 chunks	+2 lines, -17 lines	0 comments	Download
M	src/test/test_handshake.py	View	1	1 chunk	+6 lines, -32 lines	0 comments	Download
D	src/test/test_handshake_hybi08.py	View		1 chunk	+0 lines, -309 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Adam Rice

https://codereview.appspot.com/90490043/diff/1/src/test/test_handshake.py File src/test/test_handshake.py (right): https://codereview.appspot.com/90490043/diff/1/src/test/test_handshake.py#newcode135 src/test/test_handshake.py:135: def test_parse_with_allow_quoted_string(self): The first part of this test is ...

12 years ago (2014-04-23 06:41:49 UTC) #2

tyoshino (chromium.org)

12 years ago (2014-04-23 07:05:00 UTC) #3

tyoshino (chromium.org)

12 years ago (2014-04-23 10:01:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r794 (presubmit successful).

Expand All Messages | Collapse All Messages