Issue 9048043: CPP: Add base/thread_checker.h.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9048043: CPP: Add base/thread_checker.h. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by pliard1

Modified:
12 years, 7 months ago

Reviewers:
Shaopeng

CC:
lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Add base/thread_checker.h. This lets make sure that the library is only called in Chromium from the UI thread. BUG=http://crbug.com/236272 R=jia.shao.peng@gmail.com Committed: https://code.google.com/p/libphonenumber/source/detail?r=570

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -36 lines)			Patch
M	cpp/src/phonenumbers/base/memory/singleton.h	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	cpp/src/phonenumbers/base/synchronization/lock.h	View	1 chunk	+22 lines, -4 lines	0 comments	Download
A +	cpp/src/phonenumbers/base/thread_checker.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
D	cpp/src/phonenumbers/base/thread_safety_check.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

pliard1

12 years, 7 months ago (2013-05-02 13:26:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r570 (presubmit successful).

Expand All Messages | Collapse All Messages