Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1054)

Issue 90480043: Do not show property panel by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by fujiwara
Modified:
10 years, 7 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Do not show property panel by default. Property panel sometimes hides text entry box on firefox in case the mode is auto-hide because firefox does not provide the right cursor locations and firefox does not update cursor locales when preedit is updated so property panel hides text entry box for a while and auto-hide is not useful with firefox and thunderbird. TEST=gsettings reset org.freedesktop.ibus.panel show

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M data/ibus.schemas.in View 1 chunk +1 line, -1 line 0 comments Download
M ui/gtk3/propertypanel.vala View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
fujiwara
10 years, 7 months ago (2014-04-23 03:41:54 UTC) #1
Peng
10 years, 7 months ago (2014-04-23 16:48:48 UTC) #2
On 2014/04/23 03:41:54, fujiwara wrote:

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b