Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 9045045: code review 9045045: net/http: add setCork function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bradfitz
Modified:
12 years, 2 months ago
Reviewers:
r, rsc, pabuhr
CC:
golang-dev
Visibility:
Public.

Description

net/http: add setCork function Largely stolen from the go.net repo. Only on Linux for now. FreeBSD 4.5+ could come later. Not in package net, as to not further contribute API to that cesspool. Future CL will use these. Update Issue 5352

Patch Set 1 #

Patch Set 2 : diff -r 8f1fb6b6f141 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8f1fb6b6f141 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8f1fb6b6f141 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
A src/pkg/net/http/cork_linux.go View 1 1 chunk +44 lines, -0 lines 1 comment Download
A src/pkg/net/http/cork_stub.go View 1 1 chunk +18 lines, -0 lines 0 comments Download
A src/pkg/net/http/cork_test.go View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M src/pkg/net/http/export_test.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13
bradfitz
Hello pabuhr@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2013-05-14 15:10:40 UTC) #1
bradfitz
CL updated with a test. On Tue, May 14, 2013 at 8:10 AM, <bradfitz@golang.org> wrote: ...
12 years, 2 months ago (2013-05-14 15:18:35 UTC) #2
r
What is TCP_CORK? Also as you note, net is already a cesspool. Should we let ...
12 years, 2 months ago (2013-05-14 16:23:24 UTC) #3
bradfitz
This was discussed in the meeting yesterday. On Tue, May 14, 2013 at 9:23 AM, ...
12 years, 2 months ago (2013-05-14 16:27:30 UTC) #4
bradfitz
Background for this CL: Peter proposed https://codereview.appspot.com/9333044/ adding a package net TCPConn.SetCork function to the ...
12 years, 2 months ago (2013-05-14 16:39:42 UTC) #5
r
I didn't hear Russ say that. Personally, I'd rather keep the mess in one place ...
12 years, 2 months ago (2013-05-14 16:49:51 UTC) #6
bradfitz
Russ: make the call. On Tue, May 14, 2013 at 9:49 AM, Rob Pike <r@golang.org> ...
12 years, 2 months ago (2013-05-14 16:50:38 UTC) #7
rsc
I don't want this in the library at all. But if it's here, it should ...
12 years, 2 months ago (2013-05-14 19:21:06 UTC) #8
r
i remain unhappy but will LGTM if rsc agrees. sockets are just foul https://codereview.appspot.com/9045045/diff/9001/src/pkg/net/http/cork_linux.go File ...
12 years, 2 months ago (2013-05-14 19:36:10 UTC) #9
rsc
I don't understand how far we are willing to go for how much performance on ...
12 years, 2 months ago (2013-05-14 19:59:55 UTC) #10
bradfitz
Peter? On Tue, May 14, 2013 at 12:59 PM, Russ Cox <rsc@golang.org> wrote: > I ...
12 years, 2 months ago (2013-05-14 20:06:13 UTC) #11
pabuhr
Russ, let me run some experiments to see if I can answer your question. I'll ...
12 years, 2 months ago (2013-05-14 20:33:35 UTC) #12
bradfitz
12 years, 2 months ago (2013-05-17 22:17:00 UTC) #13
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b