Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 90420043: Fix migration wrt invalid constraints.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by bac
Modified:
5 years, 2 months ago
Reviewers:
j.c.sackett, mp+216765
Visibility:
Public.

Description

Fix migration wrt invalid constraints. The migration 026 for rewriting contraints to be space-separated worked for staging. When run on production it had errors due to some of the bundles on production being older than the more restrictive bundle proofing requirements. Those bundles were in essence grandfathered in and never subject to the stricter rules. At least one bundle had an obsolete 'cpu' constraint and that caused the migration to fail since it was not checking for the thrown ValueError in this situation. The migration now checks for ValueError and will remove the affected bundle from the target database and proceed. The functions are now noted to throw ValueError. Test was added for this situation and logging checked. https://code.launchpad.net/~bac/charmworld/026-3/+merge/216765 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -18 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/migrations/versions/026_convert_comma_constraints.py View 1 chunk +10 lines, -1 line 0 comments Download
M charmworld/migrations/versions/tests/test_migrations.py View 4 chunks +47 lines, -17 lines 0 comments Download
M charmworld/models.py View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
5 years, 2 months ago (2014-04-22 18:37:36 UTC) #1
j.c.sackett
Looks good, Brad. Good luck with this round.
5 years, 2 months ago (2014-04-22 18:44:11 UTC) #2
j.c.sackett
5 years, 2 months ago (2014-04-22 18:50:26 UTC) #3
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b